I think that, given the relative obscurity of this particular Ant
target (it will only interest the dev team...), I will remove the
DependencyFinder stuff but allow the target to link to it if it is
separately installed. It's not worth the hassle for a feature that
will be run infrequently, and it adds ~500k to the distro.
What I will do, however, is add the output from the last run that
compares 2.6 and 2.8 to the docs folder. That will be useful for
Murray, certainly. :)
Andrew
On Jul 4, 2008, at 3:44 PM, Craig L Russell wrote:
Hi Andrew,
On Jul 3, 2008, at 5:42 PM, Andrew Jaquith wrote:
This is part of JarJarDiff -- part of the DependencyFinder package
that allows is to diff the APIs of the current JSPWiki jar against
previous versions. I have included the license in the docs folder
(LICENSE.DependencyFinder). The license for both this XSL file and
the related DependencyFinder.jar file is not an Apache license, but
it seems Apache-friendly. We do have other software (binary jars,
admittedly) that aren't Apache-licensed (HSQL and Akismet, just to
name two).
This license is a one-off that needs approval by the legal
committee. If it were an exact copy of one of the "known" licenses
(BSD, NCSA, etc.) we could just attribute it and be done.
Once approved, it's quite ok to include code with permissive
licenses like this in Apache distributions, if there is no
alternative.
This is documented at http://www.apache.org/legal/3party.html
What would you recommend for non-binary code like this? One option
is to simply pull it out of the distro. The API-diff Ant task won't
be widely used, other than by the dev team.
Assuming we get approval from legal, it's ok to include in
distributions.
In order to ask legal for permission to include "seems Apache-
friendly" but non-standard code, I'll need the actual license/
copyright text. Can someone point me to all of the known
dependencies? (Maybe running RAT on the distribution will give you
enough information...)
Craig
On Jul 3, 2008, at 8:27 PM, Craig L Russell wrote:
Seems odd to be adding non-Apache-licensed code right after the
code base was declared all-Apache-license.
What's the plan to get this code licensed under Apache?
Craig
On Jul 3, 2008, at 5:09 PM, [EMAIL PROTECTED] wrote:
Author: ajaquith
Date: Thu Jul 3 17:09:53 2008
New Revision: 673882
URL: http://svn.apache.org/viewvc?rev=673882&view=rev
Log:
Added Ant target 'api-diff' which allows arbitrary diffing
against previous JSPWiki.jar artifacts. It prints a nicely
formatted HTML page describing public API differences. The report
file is tests/reports/API-changes.html.
Added:
incubator/jspwiki/trunk/tests/etc/DiffToHTML.xsl
incubator/jspwiki/trunk/tests/etc/dependencyfindertasks.properties
incubator/jspwiki/trunk/tests/etc/log4j.properties
Added: incubator/jspwiki/trunk/tests/etc/DiffToHTML.xsl
URL:
http://svn.apache.org/viewvc/incubator/jspwiki/trunk/tests/etc/DiffToHTML.xsl?rev=673882&view=auto
=
=
=
=
=
=
=
=
=
=
=
===================================================================
--- incubator/jspwiki/trunk/tests/etc/DiffToHTML.xsl (added)
+++ incubator/jspwiki/trunk/tests/etc/DiffToHTML.xsl Thu Jul 3
17:09:53 2008
@@ -0,0 +1,307 @@
+<?xml version="1.0"?>
+
+<!--
+ Copyright (c) 2001-2007, Jean Tessier
+ All rights reserved.
+
+ Redistribution and use in source and binary forms, with or
without
+ modification, are permitted provided that the following
conditions
+ are met:
+
+ * Redistributions of source code must retain the above
copyright
+ notice, this list of conditions and the following
disclaimer.
+
+ * Redistributions in binary form must reproduce the
above copyright
+ notice, this list of conditions and the following
disclaimer in the
+ documentation and/or other materials provided with the
distribution.
+
+ * Neither the name of Jean Tessier nor the names of his
contributors
+ may be used to endorse or promote products derived
from this software
+ without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS
+ "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
BUT NOT
+ LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS FOR
+ A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
REGENTS OR
+ CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL,
+ EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO,
+ PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR
+ PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF
+ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING
+ NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS
+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+-->
+
+<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform
">
+
Craig L Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
Craig L Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
