[
https://issues.apache.org/jira/browse/JSPWIKI-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619576#action_12619576
]
Harry Metske commented on JSPWIKI-324:
--------------------------------------
The fundamental question here is :
Should a referring page allowed to be modified (changing links to point to a
renamed page) when a referred page is renamed by someone that has no write
access to the referring page ?
I think it should, the changes made to the write-protected referring page are
done in a controlled way, the user renaming the referred page has no control
over what is changed in the referring page, that's being done by the
PageRenamer.
The VersioningFileProvider handles this situation correctly, it seems your
custom provider not.
I think you should fix your custom provider to allow modifying a
write-protected referring page while renaming a referred page.
> ReferenceManager throws NullPointerException when renaming read-only page
> -------------------------------------------------------------------------
>
> Key: JSPWIKI-324
> URL: https://issues.apache.org/jira/browse/JSPWIKI-324
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 2.6.2
> Environment: RHEL 5.1, Apache Tomcat 6.0.16, JSPWiki 2.6.2
> Reporter: Thomas Hinterndorfer
> Assignee: Harry Metske
> Priority: Minor
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> I am using custom Page and Attachment Providers, so this issue may not be
> recreatable in other environments.
> These providers store the contents in the CMS of the company, i am working
> for.
> I have 2 pages, created by different users, linking each other. If i change
> the ACL (in the CMS) for page A, so the other user may only read, but not
> change it, then rename page B with the user, who may only read page A, the
> referring link on page A is not updated, because the user doesn't have write
> permissions. But if i then rename page A, i get a NullPointerException from
> the ReferenceManager (the page name is updated correctly), it's only
> confusing for users to get an error, and other references to the page aren't
> updated too. If i restart JSPWiki after renaming page B, there's no error. So
> i guess, the ReferenceManager is trying to update the link, it fails due to
> the lack of permissions, and the ReferenceManager stores wrong information
> and tries to update non-existing references when renaming page A. This would
> explain why there's no error after restarting, because the references are
> rebuilt.
> Text from Error.jsp:
> Error Message
> An unknown exception java.lang.NullPointerException was caught by
> Error.jsp.
> Exception
> java.lang.NullPointerException
> Place where detected
> com.ecyrd.jspwiki.ReferenceManager.clearPageEntries(), line 885
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
