[
https://issues.apache.org/jira/browse/JSPWIKI-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636934#action_12636934
]
Dirk Frederickx commented on JSPWIKI-395:
-----------------------------------------
I think also this is useful to still take this in 2.8, as it are minor changes.
If ok, i'll commit this very soon.
No need for a patch, the description is pretty clear -- txs Andrew.
dirk
> Unbalanced tags in default template
> -----------------------------------
>
> Key: JSPWIKI-395
> URL: https://issues.apache.org/jira/browse/JSPWIKI-395
> Project: JSPWiki
> Issue Type: Bug
> Components: Default template
> Affects Versions: 2.8
> Environment: All
> Reporter: Andrew Jaquith
> Assignee: Dirk Frederickx
> Fix For: 3.0
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Dirk --
> I've written a tool for JSPWiki 3.x that parses JSPs and tries to migrate
> them to a Stripes-compatible format. The tool works pretty well now, and
> among other things detects unbalanced tags. I've found 6 files in the default
> template that have errors. They are:
> * AttachmentTab.jsp -- line 49: </wiki:Permission> should move after line 51:
> </form>
> * EditTemplate.jsp -- lines 28 and 28 should be restructured; see below
> * InfoContent.jsp -- line 141: <input> needs a trailing / to finish the tag
> * admin/UserManagement.jsp -- line 114: needs a closing </tr>. Also, line
> 121: </div> should move after line 123
> * editors/FCK.jsp -- line 130: </td> tag after <label> should be removed.
> Also, line 132: double quote (") immediately before closing /> should be
> removed.
> * editors/plain.jsp -- line 196: </td> tag after <label> should be removed.
> Also, line 216: last </div> should be removed.
> Now, this is what I *think* should be done. Can you confirm that this is
> correct before we (you, I guess) commits?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.