My point being that if this is a problem with newbies who do not
understand that the slash is required, they will need the slash; but
if you've got an exotic configuration you're probably savvy enough to
know what you want, and in that case you don't really want the engine
to change your configs based on what it thinks is good.
Hence fixing it in the installer instead of the WikiEngine.
/Janne
On 12 Nov 2008, at 23:03, Harry Metske wrote:
Well, to be honest, I don't see the problem, could you explain a
bit more ?
And I think WikiEngine is a better place, people don't always use the
Installer, if you modify the jspwiki.properties by hand we now still
tolerate the absence of the trailing slash.
regards,
Harry
2008/11/12 Janne Jalkanen <[EMAIL PROTECTED]>
Isn't this a problem if someones base path ends with a non-slash
thing?
For example, "http://myorg/myredirectservlet?redirurl=";
Better to fix in the installer?
/Janne
--- incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/WikiEngine.java
(original)
+++ incubator/jspwiki/trunk/src/com/ecyrd/jspwiki/WikiEngine.java
Wed Nov
12 12:24:43 2008
@@ -498,7 +498,11 @@
m_saveUserInfo );
m_useUTF8 = "UTF-8".equals
( TextUtil.getStringProperty(
props, PROP_ENCODING, "ISO-8859-1" ) );
- m_baseURL = TextUtil.getStringProperty( props,
PROP_BASEURL, "" );
+ m_baseURL = TextUtil.getStringProperty( props,
PROP_BASEURL, ""
);
+ if( !m_baseURL.endsWith( "/" ) )
+ {
+ m_baseURL = m_baseURL + "/";
+ }
m_beautifyTitle = TextUtil.getBooleanProperty( props,
