[
https://issues.apache.org/jira/browse/JSPWIKI-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660410#action_12660410
]
Andrew Jaquith commented on JSPWIKI-452:
----------------------------------------
That is, indeed, a bit too rigorous. I am sorry.
We might consider, as a matter of good form, probably call
WikiEngine.shutdown() during as part of JUnit tearDown().
However, it might be sufficient simply to log an error, and/or throw a stack
trace, when we encounter duplicate registered JMX beans.
> JMX implementation does not support More than one JSPWiki instance
> ------------------------------------------------------------------
>
> Key: JSPWIKI-452
> URL: https://issues.apache.org/jira/browse/JSPWIKI-452
> Project: JSPWiki
> Issue Type: Bug
> Components: Core & storage
> Affects Versions: 3.0
> Environment: JSPWiki 3.0
> Reporter: Harry Metske
> Assignee: Harry Metske
> Priority: Minor
> Fix For: 3.0
>
>
> The current JMX implementation does not handle multiple JSPWiki instances per
> JVM very well.
> This is true for both the new LoggerMBeans as for the other Admin type MBeans.
> The problem is that the ObjectName does not make the MBeans unique.
> Example names:
> JSPWiki:component=Core,name=Core bean
> JSPWiki:component=Loggers,name=com.ecyrd.jspwiki.WikiEngine
> So, depending on the order of startup, JSPWikiA or JSPWwikiB gets the MBean.
> This can be a bit dangerous, you think you reload the Search manager for A,
> but B gets it.
> But apparently we don't have that many users that use both multiple wiki's
> and the JMX.
> I think we need something that makes the MBean names unique. Question is what
> do we use :
> 1. property jspwiki.applicationName ? (still no guarantee)
> 2. context root of webapp (also no guarantee)
> 3. a random string appended, so this would make it like :
> JSPWiki-BGJSKIR:component=Core,name=Core bean, not very elegant
> 4. something perfect, any idea's ?
> The current AdminBeanManager also has a minor bug, saying it registers an
> MBean while it didn't, I'll fix that soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
