Janne -- This is yet another email about JCR. :)
Quick question: when does a page "exist"? At present, a page exists when ContentManager says it does; that is, a node representing that page has been added to the JCR. But our checks don't consider whether the node has actually been **saved**. So, we have a few situations where page nodes can be "added" and therefore exist from the point of view of ContentManager, but really don't in the filesystem. Case in point: page-save approval workflow tests are failing because, in order to create the WikiContext, we create a page node but it does not get saved until somebody actually approves it. To bring some clarity to this, I'd propose we define a page node as "existing" of it 1) is present in the JCR, and 2) has been saved; i.e., Node.isNew() returns false. I can't think of any reason why this wouldn't work, or any odd side-effects. I suppose it's possible that within a particular thread, multiple page adds could step on each other before the JCR Session save(). But that's about it, and any cases where we see this could be worked around easily. Andrew
