I haven't committed to doing this just yet; I'm being careful not to
step on Jannes's toes, because he wrote the SpamFilter code, and I
want his input before I go too much further.
But yes, I agree that if we were to rework the code, moving the
messages into bundles would be good. I find the messages a bit cheeky
also, and it would be nice to be able to customize them.
The basic idea you described (splitting the SpamFilter into smaller
chunks) is what I had in mind for the refactoring. This is what I
meant by the reference to a series of new stackable "Inspector" classes.
Andrew
On Sep 18, 2009, at 8:23, "Dalen, Andre van" <[email protected]
> wrote:
Hi Andrew,
Looks like you also could split the combined filter into a few more
basic
filters and let the JSPWiki take care of combining them.
(i.e. a chapta filer, spamwords filter, externallinks filter, number
of
edits filter, etc.)
While you're at it, could you have a look at making the messages
configurable?
I have been confronted by users that did not like the tongue-in-cheek
messages telling them they could not do what they wanted because of
some
Herb :-)
I ended up hiding the SpamFilter in a closed collapsebox because of
it.
regards, Andre
-----Original Message-----
From: Andrew Jaquith [mailto:[email protected]]
Sent: vrijdag 18 september 2009 14:13
To: [email protected]
Cc: [email protected]
Subject: Re: ReCaptcha?
Good points. I do think it makes sense to have a reCaptcha option
among others that might arise.
On a side note, I'm fooling around with SpamFilter to make it a lot
more extensible. I have this idea about stackable "Inspector" objects
that extract the current (rather complex) logic into separate
implementions, but which collaborate on the outcome. The driver for
this was the need to have better integration with the view layer and
additional captcha systems.
I'll run the design by you when it firms up, but my initial
experiments look very promising. I think you'll like it a lot.
Andrew
On Sep 16, 2009, at 17:21, Janne Jalkanen <[email protected]>
wrote:
Google is well known for their embrace and extinguish -tactic. It
would be unlikely that ReCaptcha will get any new development.
The captcha system we have is designed to be pluggable, so it should
be possible to add other systems as well. More the merrier; then we
won't be subject to corporate whims...
/Janne
On Sep 16, 2009, at 23:31 , Andrew Jaquith wrote:
Any thoughts on ReCaptcha? Google just bought them. I thought this
might be a nice addition to what we offer now (Asirra) -- maybe
even a
replacement for it.
Andrew
