nope, not recommended in the priha Changelog 0.5, also the test results are
not better :-(quite a bit more errors and failures.

Harry

2009/10/12 Harry Metske <[email protected]>

> I almost checked in that priha version yesterday :-)
> Should I wait, or commit that one in ?
>
> I kept some test-stats BTW:
> http://people.apache.org/~metskem/tests/jspwiki-testresult.html
> (you can see the good results from Andrew's work the last few days)
>
>
> regards,
> Harry
>
> 2009/10/12 Janne Jalkanen <[email protected]>
>
>
>> Yup, this is a known problem in 0.3.2... Should be fixed in the current
>> trunk.
>>
>> /Janne
>>
>>
>> On Oct 12, 2009, at 07:48 , Andrew Jaquith wrote:
>>
>>  Janne, I'm digging into more bugs...
>>>
>>> The page-renamer tests haven't worked for  a while. I think I know why.
>>>
>>> ContentManager.renamePage(WikiContext, fromPage, toPage) has a bug.
>>> Specifically, after this code executes:
>>>
>>>           getCurrentSession().move( getJCRPath( fromPage ),
>>> getJCRPath( toPage ) );
>>>           getCurrentSession().save();
>>>
>>> ...fromPage is still accessible after this point. I.e.,
>>> engine.getPage(fromPage) returns a valid page. Moreover, it shares the
>>> same JCR UUID as the toPage. That would suggest that something isn't
>>> getting cleaned up properly inside of Priha SessionImpl.move().
>>>
>>> Of the 18 failing PageRenamerTest tests, fixing this bug would
>>> probably get rid of 15 of them.
>>>
>>> Thoughts?
>>>
>>> Andrew
>>>
>>
>>
>

Reply via email to