I like to see it too, please email, or maybe stick it somewhere on
www.jspwiki.org

regards,
Harry

2009/11/29 Janne Jalkanen <[email protected]>

>
> Sent it to you directly - others, let me know if you want to see it.
>
> Well, we've got JSPWikiTestBase class, which extends TestCase.  So we could
> use that as well and just start extending our tests from it instead directly
> from TestCase.
>
> /Janne
>
>
> On Nov 29, 2009, at 00:52 , Andrew Jaquith wrote:
>
>  Janne, I think your attachment got stripped out. Can you re-send
>> (maybe directly?)
>>
>> I agree that we ought to figure out some way of using some sort of
>> singleton (or singleton-per-wikiengine) object to stash the results of
>> findImplementations(). Not sure how this would work with JUnit, though
>> -- I should do some research. What we'd need is the ability to create
>> test fixture objects that persist across the entire run...
>>
>> Andrew
>>
>> On Sat, Nov 28, 2009 at 4:48 PM, Janne Jalkanen
>> <[email protected]> wrote:
>>
>>> Folks, here's a screenshot from JProfiler.  This should explain why our
>>> tests are fairly slow...
>>>
>>>
>>>
>>>
>>>
>>> Simply put; we're not using EhCache, and also we're calling Stripes
>>> ResolverUtil.findImplementations twice per WikiEngine startup.  So it
>>> might
>>> make sense to move findImplementations() calls into a singleton or
>>> something.  But I'm not too sure whether it makes sense considering
>>> restarts
>>> - or perhaps restarts should clean away the singleton cache?
>>>
>>> (This is after about 700 tests were run; I didn't want to wait until they
>>> had all finished, since it had already taken about two hours with
>>> profiling
>>> on...)
>>>
>>> Priha can be seen taking quite a lot of time as well, but that's because
>>> it
>>> needs to hit the disk all the time.  More optimization for FileProvider
>>> is
>>> needed, but partly it's also because we're not caching anything.
>>>
>>> /Janne
>>>
>>>
>

Reply via email to