hmm you beat me by a second! I'll go with what the majority expresses: as you say I don't think that it should be a stopper for current 2.9.0, but, on the other hand, it would be nice to have both build.xml corrected and JSPWIKI-683 included..
br, jp On Thu, May 3, 2012 at 5:48 PM, Florian Holeczek <flor...@holeczek.de>wrote: > Hi Janne, > > it's an essential requirement to be able to reproduce exactly the released > artifacts from source. In this case, since only the build.xml seems to be > affected, it's not that dramatic IMO. However, we could seize the > opportunity and restart the vote, voting on a 2.9.0-incubating-1 with a > correct build.xml and JSPWIKI-683 fixed. > What do the others think? > > Regards > Florian > > > ----- Ursprüngliche Mail ----- > Von: "Janne Jalkanen" <janne.jalka...@ecyrd.com> > An: jspwiki-dev@incubator.apache.org > Gesendet: Donnerstag, 3. Mai 2012 13:27:54 > Betreff: Re: build.xml, WAS: Re: [VOTE] Release JSPWiki version > 2.9.0-incubating > > > Oops, that's my bad. Yes, you need to manually change the build.xml for > this particular tag. Shall we reroll the artifacts and the tag? > > /Janne > > On 3 May 2012, at 01:36, Florian Holeczek wrote: > > > Hi all, > > > > during my checks, I wasn't able to reproduce the source zip file due to > one single point. > > Could you please check whether the correct build.xml gets included in > your environments? Over here, it seems to always include the one from the > trunk, although I made svn.tag = tags/jspwiki_2_9_0 > > > > Regards > > Florian > > > > > > ----- Ursprüngliche Mail ----- > > Von: "Juan Pablo Santos Rodríguez" <juanpa...@apache.org> > > An: jspwiki-dev@incubator.apache.org > > Gesendet: Mittwoch, 2. Mai 2012 13:05:30 > > Betreff: [VOTE] Release JSPWiki version 2.9.0-incubating > > > > This is an incubator release for Apache JSPWiki, version > 2.9.0-incubating. > > > > It fixes the following issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12319521 > > > > *** Please download, test and vote by 72 hours from now. > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Source and binary files: > > http://people.apache.org/~jalkanen/JSPWiki/2.9.0/ > > > > The tag to be voted upon: > > http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0/ > > > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > > http://www.apache.org/dist/incubator/jspwiki/KEYS > > > > > > regards, > > juan pablo > >
