Juan, Also committed 2 minor fixes. OK for RC,
txs dirk On Fri, Jul 6, 2012 at 7:29 PM, Harry Metske <harry.met...@gmail.com> wrote: > Juan Pablo, > > no problem with the suggested upgrades and refactoring. > I just committed some minor (doc) corrections for JSPWIKI-731. > > Thanks for all your work ! > > regards, > Harry > > > 2012/7/6 Juan Pablo Santos Rodríguez <juanpablo.san...@gmail.com> > > > Hi, > > > > couple of days ago I was finally able to solve my problems regarding the > > Lucene exceptions, as sad as it looks, in the most ancient windows-way: > > rebooting (computer at home is up 99% of the time..). So I was feeling > now > > would be a good moment to push a new RC, hoping that this time it will > > become the first ASF release. Before doing that however, I was thinking > of > > pushing a coulpe of small changes: > > > > - upgrading commons-lang to commons-lang3: aside from the code, this > could > > imply upgrading other commons-* libraries, if they do depend on > > commons-lang and don't know if that would cause to 3rd party plugins, if > > they do depend on that library. Another possibility could be simply > upgrade > > commons-lang to 2.6, which is the latest from 2.x and most probably won't > > break anything. > > > > - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to > > retrieve and close Lucene indexes. Have that small change from days ago, > > when I was pursuing ghosts; the functionally of the class remains exactly > > the same, it's just a bit tinier. > > > > WDYT? Does anyone want to push in (or get pushed in) any other thing > before > > making the next RC? > > > > > > br, > > juan pablo > > > > [#1] > > > > > http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html > > >
