[ 
https://issues.apache.org/jira/browse/JSPWIKI-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563511#comment-13563511
 ] 

Glen Mazza commented on JSPWIKI-758:
------------------------------------

Actually, the above test fails anyway without an RCS provider:

type="org.apache.wiki.providers.ProviderException">org.apache.wiki.providers.ProviderException:
 RCS checkin failed
        at 
org.apache.wiki.providers.RCSFileProvider.putPageText(RCSFileProvider.java:425)
        at org.apache.wiki.PageManager.putPageText(PageManager.java:305)
        at 
org.apache.wiki.PageManager$SaveWikiPageTask.execute(PageManager.java:747)
        at 
org.apache.wiki.workflow.Workflow.processCurrentStep(Workflow.java:763)
        at org.apache.wiki.workflow.Workflow.start(Workflow.java:678)
        at 
org.apache.wiki.workflow.WorkflowManager.start(WorkflowManager.java:79)
        at org.apache.wiki.WikiEngine.saveText(WikiEngine.java:1752)
        at org.apache.wiki.TestEngine.saveText(TestEngine.java:336)
        at 
org.apache.wiki.stress.StressTestRCSProvider.testMillionChanges(StressTestRCSProvider.java:99)
Caused by: java.io.IOException: Cannot run program "ci" (in directory 
"/tmp/testrepository"): error=2, No such file or directory


StressTestSpeed also needs updating for the new situation:

Testsuite: org.apache.wiki.stress.StressTestSpeed
Tests run: 2, Failures: 0, Errors: 2, Time elapsed: 24.863 sec

Testcase: testSpeed1 took 13.366 sec
        Caused an ERROR
RCS checkin failed
org.apache.wiki.providers.ProviderException: RCS checkin failed
        at 
org.apache.wiki.providers.RCSFileProvider.putPageText(RCSFileProvider.java:425)
        at 
org.apache.wiki.providers.CachingProvider.putPageText(CachingProvider.java:584)
        at org.apache.wiki.PageManager.putPageText(PageManager.java:305)
        at 
org.apache.wiki.PageManager$SaveWikiPageTask.execute(PageManager.java:747)
        at 
org.apache.wiki.workflow.Workflow.processCurrentStep(Workflow.java:763)
        at org.apache.wiki.workflow.Workflow.start(Workflow.java:678)
        at 
org.apache.wiki.workflow.WorkflowManager.start(WorkflowManager.java:79)
        at org.apache.wiki.WikiEngine.saveText(WikiEngine.java:1752)
        at org.apache.wiki.TestEngine.saveText(TestEngine.java:336)
        at 
org.apache.wiki.stress.StressTestSpeed.testSpeed1(StressTestSpeed.java:84)
Caused by: java.io.IOException: Cannot run program "ci" (in directory 
"/tmp/testrepository"): error=2, No such file or directory
        at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
        at java.lang.Runtime.exec(Runtime.java:615)
        at java.lang.Runtime.exec(Runtime.java:448)
        at 
org.apache.wiki.providers.RCSFileProvider.putPageText(RCSFileProvider.java:399)
Caused by: java.io.IOException: error=2, No such file or directory
        at java.lang.UNIXProcess.forkAndExec(Native Method)
        at java.lang.UNIXProcess.<init>(UNIXProcess.java:135)
        at java.lang.ProcessImpl.start(ProcessImpl.java:130)
        at java.lang.ProcessBuilder.start(ProcessBuilder.java:1021)

Other tests seem to work fine with this change.
                
> should we drop support for RCS (Revision Control System) ?
> ----------------------------------------------------------
>
>                 Key: JSPWIKI-758
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-758
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.9.1
>         Environment: All
>            Reporter: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> This is less or more of a poll if there is still the need for RCS support in 
> JSPWiki.
> RCS (http://en.wikipedia.org/wiki/Revision_Control_System) was created in 
> 1982), and my impression is that nobody is using it anymore (in JSPWiki).
> We do have quite some tweaks in the build scripts and so on. 
> Dropping support would make the project again a bit more simple.
> Your votes please!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to