[ 
https://issues.apache.org/jira/browse/JSPWIKI-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565061#comment-13565061
 ] 

Glen Mazza commented on JSPWIKI-651:
------------------------------------

Sure, feel free to do so (as well as add to it...) or I will on Wednesday 
evening.  Yes, we will certainly update to the Tomcat 7 plugin -- my coworker 
has put in lots of changes in the upcoming 2.1 release of that plugin, we're 
just awaiting when he has time to release it.  (We can use the current Tomcat 7 
plugin, it's just much more limited than the upcoming 2.1 one.)  We are at the 
"mvn clean package" or "mvn clean install" level -- namely the tests are all 
running fine (may still be a hiccup in one or two of the Stress Test cases, I 
was unable to replicate today.)  

I think instead of tomcat:exec-war, tomcat:run-war is preferred because (1) it 
still uses an embedded Tomcat (no local tomcat needed) but (2) it uses the very 
same WAR that you would have if you deployed it on Tomcat standalone.  But we 
can configure both.

Upcoming Work (anybody, feel free to jump in where you'd like):
1.) Populate the Maven war plugin defined in this pom.xml with the items needed 
for the WAR, to get something that can be placed on Tomcat.  Goal: for the WAR 
that mvn clean installs to run OOTB on a standalone Tomcat (if not yet via 
tomcat:run-war).
2.) Active the Selenium plugin to run the webtests (I think 1 before 2 here 
because I'm guessing Selenium on Maven will use the very same WAR that we 
output for deployment to Tomcat.)
3.) Mavenize the project folder structure so we have less work to do in the 
maven-antrun-plugin, as well as needing to define nonstandard locations in the 
<build> (sourceDirectory, testSourceDirectory, and resources areas) -- if we do 
any of this, the ant build.xml file will need to be reconfigured to the new 
locations so it continues to work.
4.) (Eventually) Convert the tests to JUnit 4.x, and (I suspect) the web tests 
will have a new *IT.java naming to indicate they are integrated tests (i.e., 
run after a WAR is created) -- I'm a little bit hazy here.
5.) Maven Rat plugin added to pom.
6.) Whatever Coburtura and other deployment stuff needs to be configured.
7.) You had a more advanced folder structure you were thinking of moving to...

Once the pom.xml is in the source repo, anytime we make a change to the 
build.xml -- new dependencies, rearranging whatever, we will need to run "mvn 
clean install" *after* an "ant clean" just to check if the pom.xml also needs 
updating.  The build.xml is still our official build until we retire it in 
favor of Maven.

                
> Convert JSPWiki to a Maven project
> ----------------------------------
>
>                 Key: JSPWIKI-651
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-651
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Daniel Johansson
>            Priority: Minor
>              Labels: ant, build, ivy, maven
>         Attachments: pom.xml
>
>
> Hello there, I was hoping to maybe one day contribute to the JSPWiki project 
> and after having checked out the trunk code and played around somewhat I was 
> thinking it would be very nice if this project used Maven.
> I'm sure most of you are familiar with Maven in one way or another, you might 
> even have a really good reason for not doing this to JSPWiki.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to