Paul Cowan created JSPWIKI-759:
----------------------------------

             Summary: Resin 4 Compatability
                 Key: JSPWIKI-759
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-759
             Project: JSPWiki
          Issue Type: Improvement
          Components: Servlet Container/Java compatibility
    Affects Versions: 2.9
         Environment: OSX 10.8.2, Oracle Java JDK 1.7.0_09

            Reporter: Paul Cowan


I am an engineer for Caucho on the Resin Application Server, and was testing 
JSPWiki on Resin version 4.0.34.  I would like to submit 2 fixes to enable 
JSPWiki to run better on Resin 4:

#1. JSPWiki is calling getOutputStream after getWriter().  The servlet spec 
dictates we throw IllegalStateException for this situation.  I see JSPWiki 
already has handling in UtilJ2eeCompat to use an OutputStream rather than a 
Writer depending on the container.  The Resin check should have "useStream = 
true".

#2. As a consequence of #1, JSPWiki serves empty content.  This is due to 
buffering inside the PrintWriter used by 
WikiJSPFilter.ByteArrayResponseWrapper.  The PrintWriter is never flushed when 
toString() is called on ByteArrayResponseWrapper.  (This may not be a Resin 
specific issue.)

I will attempt to attach a patch file to this bug report containing my fix to 
WikiJSPFilter.java.




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to