On 04/30/2013 06:51 PM, Juan Pablo Santos Rodríguez wrote:
Hi!
comments inline
On Tue, Apr 30, 2013 at 11:42 PM, Glen Mazza <glen.ma...@gmail.com> wrote:
Hi Team, a few notes:
1.) In your local {jspwiki_home}/lib directory, please delete these two
files: jsonrpc-1.0.jar and jrcs-diff-0.4.2.jar. When you build the
project again, Ant will download them again with names precisely matching
what is in the Maven Central repository. This way, when we do a diff -r
between the Maven and Ant WARs to check equivalence it won't keep reporting
that Ant is missing two JARs and Maven is missing another two, when in fact
they're the same but just with different names.
ok, also, 'til we swicth to maven, the .classpath file needs to be updated
too.
Updated.
2.) When we go to a two-tier pom.xml (Juan Pablo's work), we may wish to
have a "distribution" submodule similar to CXF here:
http://svn.apache.org/viewvc/**cxf/trunk/distribution/<http://svn.apache.org/viewvc/cxf/trunk/distribution/>,
it would allow us to nicely store the LICENSE, Notice, and other static
text information away from the development folders:
http://svn.apache.org/viewvc/**cxf/trunk/distribution/src/**main/release/<http://svn.apache.org/viewvc/cxf/trunk/distribution/src/main/release/>.
didn't thought of it, but I think it's a great idea, would you mind opening
a JIRA for this, so we can track it?
Done (JSPWiki-1776).
3.) Does anyone know if we need src/images/jspwiki_alert_**icons.xcf?
(It's a GIMP image file), AFAICT by grepping the source code it's
completely unused by the project so I'd like to delete it.
+1 on removing it
Gone now. (Gambling no one else will see a need for it.)
4.) Do we need the "corepageszip" target in the build.xml? I don't know
what it's used for: http://svn.apache.org/viewvc/**
incubator/jspwiki/trunk/build.**xml?revision=1477835&view=**markup#l642<http://svn.apache.org/viewvc/incubator/jspwiki/trunk/build.xml?revision=1477835&view=markup#l642>.
I'd like to remove it if we aren't using it anymore--fewer
distractions, the better.
it's used as part of the dist target, to bundle the wikipages in the zipped
bin distribution, one file per language. On a Maven equivalent they would
be normal jar modules (jspwiki-[en|fi|de|etc.]-wikipages), one per
language, without java classes and the wikipages living at
src/main/resources. Probably they should be submodules of i.e.,
jspwiki-wikipages, something alike the module for IT tests living at the
maven branch
Perhaps the Maven assembly plugin can play a helpful role here, it
basically creates multiple JARs, all of which are a subset of whatever
the module itself would generate as a whole, I've used it before:
https://github.com/gmazza/blog-samples/blob/master/web_service_tutorial/service/pom.xml#L32
and
https://github.com/gmazza/blog-samples/blob/master/web_service_tutorial/service/src/assembly/jaxws-jar.xml
Regards,
Glen
