Hi,
regarding the build.properties.win file, iIt's intented to be used as a
replace value at line 66 of build.xml. I think it's highly useful for
windows users, it has some sensible default values for that OS. Appart from
that, what is most important is the 4 "\"'s advice in the
build.properties.win file, which isn't obvious and not knowing it can led
to a lot of headaches.
I'm +1 on removing that file only if we move that advice to the
build.properties file + some of the values with 4 "\", preceded with a #,
so they can serve as examples for windows users.
As for the rest of the files, I'm +1 on removing them.
br,
juan pablo
On Thu, May 2, 2013 at 6:41 AM, Harry Metske <harry.met...@gmail.com> wrote:
> Glen,
>
> I do not use Windows, so from me +1 on removing the stuff, including the
> install.sh.
>
> regards,
> Harry
>
>
>
> On 2 May 2013 05:18, Glen Mazza <glen.ma...@gmail.com> wrote:
>
> > Team, I'd like to get rid of build.bat, build.sh, and
> build.properties.win
> > all in the home folder -- to build the app, just type "ant" or "mvn".
> > (Also install.sh, which, referencing Tomcat 3.x, is apparently useless
> > today.) But, first a question on build.properties.win -- do we really
> need
> > it? I don't have Windows so I can't confirm its claim that
> > build.properties won't work with it, quote in build.properties.win:
> >
> > # Java and Windows do not mix too well, so you will have to put
> > # four \'s for every \ in the path...
> > #
> > @appname@=JSPWiki
> > @pagedir@=C:\\\\temp\\\\**wikipages
> > @logfile@=C:\\\\temp\\\\**jspwiki.log
> > @securitylog@=C:\\\\temp\\\\**security.log
> > @spamlog@=C:\\\\temp\\\\**spamlog.log
> > ...
> >
> > Does anyone use Windows for building JSPWiki and can confirm
> > build.properties won't work with it? I know Ant has a
> > "${/file/./separator/}"[1] that can be used if necessary to have
> something
> > portable to both *nix and Windows (and I've never heard of the need for
> > O.S.-specific file separators when using Maven) -- getting rid of the
> need
> > for two separate build.properties files (if, indeed, there is such a
> need),
> > will help with Mavenization.
> >
> > Regards,
> > Glen
> >
> > [1] http://ant.apache.org/manual/**Types/mapper.html<
> http://ant.apache.org/manual/Types/mapper.html>
> >
>
