[ 
https://issues.apache.org/jira/browse/JSPWIKI-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675802#comment-13675802
 ] 

Glen Mazza commented on JSPWIKI-779:
------------------------------------

No, I'm not being sarcastic at all, I have more than enough on my plate, I was 
only taking it 'cuz I didn't want JP to be distracted taking care of what was 
just annoying me.  If you're confident enough with your patch please go ahead 
and apply it, else I'll look at it later.  Right now I'm going to fill up the 
resource files with the submitted translations (I don't think your past commits 
handled those, but I'll look.)
                
> Refactor TemplateManager#listLanguages(PageContext pageContext)
> ---------------------------------------------------------------
>
>                 Key: JSPWIKI-779
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-779
>             Project: JSPWiki
>          Issue Type: Improvement
>    Affects Versions: 2.10
>            Reporter: Juan Pablo Santos Rodríguez
>            Assignee: Glen Mazza
>            Priority: Minor
>         Attachments: JSPWIKI-799.patch
>
>
> Currently TemplateManager#listLanguages(PageContext pageContext) searches 
> classpath for files matching templates/default_??.properties, ?? standing for 
> a locale code (en, es, pt_BR, etc.).
> This has an unfortunate side-effect: the templates/default.properties must be 
> copied to templates/default_en.properties on build time so english language 
> is properly detected.
> Refactoring TemplateManager#listLanguages(PageContext pageContext) so it 
> matches templates/default.propertie to english locale will allow us to drop 
> the maven-antrun-plugin execution on jspwiki-war module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to