+1 providing something catches the exception and DOES something with it. Just catching and returning null is worse.

Harry Metske wrote:

+1



2009/3/12 Janne Jalkanen <[email protected]>

Simple enough reason: getPage(WikiName,int) is not catching the
PathNotFoundException - look at the catch clause in getPage(WikiName) ;-).
It should do that and return null.

My bad, sorry!

(A general question, should we start throwing something like
PageNotFoundExceptions as opposed to returning nulls? That would encourage a
bit safer coding and would eliminate a number of if(getPage() == null) tests
across the codebase.)

/Janne


Reply via email to