Hi Peter, hi all, first of all, many thanks for taking the time to look at my code and answering. Given the quietness of this list over the past months I wasn't sure whether to expect any answer at all!
Peter Geirnaert schrieb: > I've been trying to keep my focus so i could review your code, but > unfortunately got too often distracted. > What I can say now is your style looks very clean Thx. I admit that I am a little bit of a coding style fanatic. I do a lot of programming in Python where a clean coding style is considered an essential part of the culture. Btw, this is my first bigger piece of Java code except some fumbling around with RoboCode. > and I think the "this." can be left away in your singleDriver > <http://codereview.appspot.com/105044/diff/1/5?context=25&column_width=80> > at lines 48 to 59 and 75. You are probably right. I created most of my code by copying from other drivers, most notably the Yamaha TG100 and TG33 and the Kawai K4 drivers, so I just copied the way it was done there. I'll check out if it still works when I remove those occurrences of "this.". > PS: What do you think about the wiki <http://jsynthlib.wikispaces.com> > I've been working on lately ? I had a look at it, but my first impression was, that there isn't that much more information than in the JSynthLib programming guide. I may be totally mistaken, I just didn't look at it very long. I was able to learn what I needed to know for patching together the Single Driver from the programming guide and looking at the source code of the other drivers and the API docs. But when I start writing the Bank driver and eventually a Patch Editor, I'll probably need more documentation and I'll surely look at your wiki again. One thing that got me a bit puzzled at first is: what are the different make targets and which ones do you use for the different system (Win, OS X, Unix) and how do you run your development copy of JSynthLib? The programming manual mentioned running JSynthLib with a "2" argument to enable debugging, but that didn't seem to work for me. I think it would be great to have a quick start guide for developers on every of the three major platforms, that just gives the exact steps to compile and run a SVN checkout. > PPS: Codereview looks like a great tool, and how did you create the > issue on sourceforge ? > I'd like to add links to information about these subjects on my wiki too. You just need a sourceforge account (which I already had) and then go to "Tracker" on the JSynthLib project page and then go to "Patches" and click on "Add new", add a summary and description and upload your diff. For the Codereview tool, you need a Google account, and then you can upload your diffs in different ways. I used the provided "upload.py" Python script, which you run from your JSynthLib SVN working dir. It will create a diff of your changes and upload them to codereview, automatically selecting the right repository. You can then add a description and then use the "Publish+Mail Comments" function to send a mail requesting for code review, like I did to the mailing list. Chris ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Jsynthlib-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jsynthlib-devel
