[
https://issues.apache.org/jira/browse/JUDDI-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842124#action_12842124
]
Jeff Faath commented on JUDDI-372:
----------------------------------
This shouldn't be a bug. Each function takes in the 'keysFound' collection and
outputs a pared down version (based on the given function's search operation).
The input list is used in an IN query and the output list is the result of that
query which just gets reassigned to the 'keysFound' variable. What is the
exact issue that brought this up?
> Inquiry Helper improperly uses assignment operator on lists.
> ------------------------------------------------------------
>
> Key: JUDDI-372
> URL: https://issues.apache.org/jira/browse/JUDDI-372
> Project: jUDDI
> Issue Type: Bug
> Components: core
> Affects Versions: 3.0.1
> Reporter: Adam Pryce
> Assignee: Jeff Faath
> Fix For: 3.0.2
>
>
> In trying to work out a subscription I found what I believe is an improper
> use of assignment in InquiryHelper.java.
> From :
> http://svn.apache.org/viewvc/webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/InquiryHelper.java?view=markup
> 264 public static List<?> findService(FindService body, FindQualifiers
> findQualifiers, EntityManager em) throws DispositionReportFaultMessage {
> 265
> 266 List<?> keysFound = null;
> 267
> 268 // First perform the embedded FindTModel search which will augment the
> tModel bag with any resulting tModel keys.
> 269 if (body.getTModelBag() == null)
> 270 body.setTModelBag(new TModelBag());
> 271 doFindTModelEmbeddedSearch(em, body.getFindQualifiers(),
> body.getFindTModel(), body.getTModelBag());
> 272
> 273
> 274 keysFound = FindServiceByTModelKeyQuery.select(em, findQualifiers,
> body.getTModelBag(), body.getBusinessKey(), keysFound);
> 275 keysFound = FindServiceByCategoryQuery.select(em, findQualifiers,
> body.getCategoryBag(), body.getBusinessKey(), keysFound);
> 276 keysFound = FindServiceByCategoryGroupQuery.select(em, findQualifiers,
> body.getCategoryBag(), body.getBusinessKey(), keysFound);
> 277 keysFound = FindServiceByNameQuery.select(em, findQualifiers,
> body.getName(), body.getBusinessKey(), keysFound);
> 278
> 279 if (body.getTModelBag().getTModelKey().size()==0)
> body.setTModelBag(null);
> 280 return keysFound;
> 281 }
> I think 274-277 should use something like
> keysFound.addAll(FindServiceBy*)
> Unfortunately in my environment I cannot build or test this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
