On Tue, Aug 19, 2014 at 11:59 AM, Aaron Bentley <[email protected]> wrote: >> This is actually your website-relation-changed hook: >> >> http://paste.ubuntu.com/8089398/ > > No, it's not: > http://manage.jujucharms.com/~juju-qa/precise/juju-reports/hooks/website-relation-changed
Sorry, I was looking at your own version which is perhaps outdated: https://jujucharms.com/~abentley/precise/juju-reports-0/?text=juju-reports#code Nevertheless, I can appreciate the underlying pattern you propose there. It's trying to build a charm that can work in a somewhat idempotent way. It will try to walk towards the same state independently from order of events or settings that come through configuration or relations. At the same time, the strictness of redoing everything all the time is not necessary, and a good example is still that website-relation-changed hook for instance. There is not, in fact, a need to rebuild your whole confguration, including stopping and starting the service, because somebody wants to know what is your address after joining that relation. >>> The charmworld charm is similar. >> >> This is reverseproxy-relation-joined there: >> >> http://paste.ubuntu.com/8089386/ > > True, I didn't call out the exceptions for the charmworld charm. For > completeness, the exceptions in charmworld are: Yeah, it definitely depends on knowing the events still. gustavo @ http://niemeyer.net -- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
