That one is an easy fix in any case. We are using a forked version of the syslog package. Removing the pid from the writeString() method should be trivial.
Gabriel On 27.08.2014 13:45, John Meinel wrote: So at the very least our default logging *doesn't* include the PID, though the rest seems sane to me. machine-0: 2014-04-08 02:00:53 INFO juju.cmd supercommand.go:296 running juju-1.19.0-precise-amd64 [gc] machine-0: 2014-04-08 02:00:53 INFO juju.cmd.jujud machine.go:129 machine agent machine-0 start (1.19.0-precise-amd64 [gc]) John =:-> On Wed, Aug 27, 2014 at 2:13 PM, Gabriel Samfira <gsamf...@cloudbasesolutions.com<mailto:gsamf...@cloudbasesolutions.com>> wrote: On 27.08.2014 08:12, John Meinel wrote: ... > I may be misremembering, but at the time that was the preferred approach. But > then someone said Go's inbuilt syslog APIs were broke, so the compromise was > to > use rsyslog forwarding. > > Does anyone else recall why it may have been said that Go's syslog APIs are > broken? The reconnect logic is broken in all the version's of the syslog api. The general consensus is that package is a mistake and should not be used. I believe there is also an issue where we couldn't format the logs the way we wanted to. (The prefix/timestamp are added by the package and cannot be configured). I think that may have been in an older version of Go. For example: http://paste.ubuntu.com/8158001/ will appear in syslog as: Aug 27 13:01:36 rossak testing[3812]: hello An example of log output streamed to all-machines.log using the syslog package: unit-vanilla2-0[1424]: 2014-08-27 09:34:14 INFO juju.worker.uniter uniter.go:324 deploying charm "local:win2012hvr2/vanilla2-0" unit-vanilla2-0[1424]: 2014-08-27 09:34:14 DEBUG juju.worker.uniter.charm manifest_deployer.go:126 preparing to deploy charm "local:win2012hvr2/vanilla2-0" unit-vanilla2-0[1424]: 2014-08-27 09:34:14 DEBUG juju.worker.uniter.charm manifest_deployer.go:102 deploying charm "local:win2012hvr2/vanilla2-0" unit-vanilla2-0[1424]: 2014-08-27 09:34:14 DEBUG juju.worker.uniter.filter filter.go:583 no new charm event I have not looked at the reconnect part though. Gabriel John =:-> -- Juju-dev mailing list Juju-dev@lists.ubuntu.com<mailto:Juju-dev@lists.ubuntu.com> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
