On 29 August 2014 20:55, Nate Finch <nate.fi...@canonical.com> wrote: > Git blame says ask Roger ;)
Sorry about that. I suspect I commented them out when trying to get some changeset to pass tests, but forgot to uncomment them and they were missed in review. I agree with not leaving commented out tests around, but I would prefer if the tests were uncommented and made to pass (fixing whatever is necessary to make them pass while thinking through to what logic they were supposed to be testing in the first place). For the record, the commented out tests were introduced here: https://codereview.appspot.com/13355044/diff/53001/environs/config/config_test.go As a further comment, in the description of that CL, it says "Still not done: providers still take defaults from the environment." I suspect that still awaits completion. cheers, rog. PS this is a good example of why it's good to avoid the use of /* */ comments, even temporarily. If I'd used //, the commented out code would have been much more obvious. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
