The bot cannot make changes to the tree and commit it back to trunk, because it doesn't have direct push rights to github. Instead it has API rights to "accept this merge". So even if it did run the changes, it wouldn't end up in trunk, and we could only reject the merge if it changed things. (As I understand it)
John =:-> On Fri, Apr 24, 2015 at 3:56 PM, David Cheney <[email protected]> wrote: > Why doesn't the bot run this hook ? > > On Fri, Apr 24, 2015 at 9:54 PM, Matthew Williams > <[email protected]> wrote: > > There's a very useful pre-push hook available for juju that does useful > > things like run gofmt, go vet, checks we can build etc. > > > > If you don't have it setup there's some lovely instructions in > > Contributing.md: > > > > https://github.com/juju/juju/blob/master/CONTRIBUTING.md#local-clone > > > > Thanks for listening > > > > Matty > > > > -- > > Juju-dev mailing list > > [email protected] > > Modify settings or unsubscribe at: > > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > > > -- > Juju-dev mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev >
-- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
