Hey All,
I think we have a mis-alignment in how we currently do reviews and
feature branches.
We've switched over to feature-branches which is great and has allowed
Moonstone to land "good enough" code into our feature branch to support
a bi-weekly demo and solicit feedback. At the same time, I feel like
we're wasting people's time asking for a +1 on code that is not intended
to be landed into master. Often this code will take shortcuts or stub
out some code, and as the lead I'll make a judgment call to circle-back
later. Reviewers don't necessarily know this.
Conversely, when we go to land the feature branch into master, these PRs
are generally rubber-stamped.
I feel like maybe we have this backwards?
-
Katherine
--
Juju-dev mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/juju-dev
