On Fri, Feb 26, 2016 at 12:04 AM Eric Snow <[email protected]> wrote:
> On Wed, Feb 24, 2016 at 11:26 PM, Andrew Wilkins > <[email protected]> wrote: > > Howdy, > > > > Occasionally I'll change a test, and some string equality test will fail > > with a wall of text. Sometimes we shouldn't be checking the whole string, > > but sometimes it's legitimate to do so, and it can be difficult/tedious > to > > spot the differences. > > > > I've just written a checker which diffs the two string args, and > colourises > > the output. You may find it useful. I'm using red/green background, but I > > also added bold for insertions, strike-through for deletions, in case > you're > > red/green colour blind. My terminal doesn't do strike-through, and your's > > probably doesn't either. Anyway, the important thing is you can see the > > difference between bits that are the same vs. insertions/deletions. > > > > Code is at github.com/axw/fancycheck. Just replace > > c.Assert("x", gc.Equals, "y") > > with > > c.Assert("x", fancycheck.StringEquals, "y") > > FYI, I added something like this to the juju repo a while back: > > https://github.com/juju/juju/blob/master/testing/base.go#L166 > > It's not a gc checker like yours but it has the same effect. > https://github.com/juju/juju/blob/master/testing/base.go#L173 :) Thanks, Eric. Maybe we should update that to use diffmatchpatch. Or we could just settle on an output filtering tool, rather than changing all of the tests. -eric >
-- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
