Nice use of docker to isolate the unholyness of testing dependencies. I like that a) i'm getting a clean environment everytime i kick this up, and b) it doesn't linger when i use -rm on the docker CLI.
You sir, are a wizard. On Tue, Feb 24, 2015 at 2:57 PM, Whit Morriss <[email protected]> wrote: > I reviewed a series of test additions to the logstash-agent charm. > > > https://code.launchpad.net/~nicopace/charms/trusty/logstash-agent/12-logstash-indexer-relation/+merge/249833 > > > https://code.launchpad.net/~nicopace/charms/trusty/logstash-agent/11-install-without-indexer/+merge/249341 > > > https://code.launchpad.net/~nicopace/charms/trusty/logstash-agent/14-log-twitter-mentions/+merge/249848 > > > https://code.launchpad.net/~nicopace/charms/trusty/logstash-agent/13-basic-logstash-indexer-stack/+merge/249852 > > > https://code.launchpad.net/~nicopace/charms/trusty/logstash-agent/15-apt-packager-log-files/+merge/249863 > > Upon inspection, there appeared to be little reason to incur the setup and > teardown cost of having these in separate test files. I recommended the > consolidation of these test into a single suite rather than a series of > executables. > > Upon reflecting on this situation, which I think is entirely > understandable looking at the corpus of available examples, I think our > current recommending testing technology encourages folks to divide their > tests logically into executable files, making logical fixtures trickier. I > think if we encourage folks make use of python's testing libraries (and a > decent runner w/ good fixture support like py.test) for functional charm > testing in python if would improve this situation. Using such tools allows > for the separation of test runner and actual individual test. They also > facilitate creation of sensible fixtures to setup and teardown deployments > only when needed saving considerable time and money and provider nicer > reporting output. > > This morning I also pushed Dockerfile for doing charm dev and review. as > many of the charm tests depend on running w/ sudo to install various > dependencies, the resulting container lets you run tests without fear or > pollution. Also installs bundletester and a few other tools. > > https://github.com/whitmo/jujubox/blob/master/CharmersDockerfile > https://github.com/whitmo/jujubox/blob/master/charmbox.md > > -w > > -- > --------------- > D. Whit Morriss > Developer, Juju Ecosystem > Canonical USA > > -- > Juju mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju > > -- All the best, Charles Butler <[email protected]> - Juju Charmer Come see the future of datacenter orchestration: http://jujucharms.com
-- Juju mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
