I reviewed a merge proposal for the apache2 charm today. The proposal added a new configuration option but a description was not added to the readme so I really didn't understand how to use it. The charm failed automated testing and I was unable to merge this proposal. I would really like to see the new configuration option documented and the amulet tests passing on this proposal, so we can ensure the apache2 charm's quality.
The review can be found here: https://code.launchpad.net/~pedronis/charms/trusty/apache2/nagios_extra_check_https/+merge/270368 I did take the time to implement some of my suggestions with a merge proposal of my own: https://code.launchpad.net/+branch/~mbruzek/charms/trusty/apache2/nagios_extra_check_https Cheers! - Matt Bruzek <[email protected]>
-- Juju mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
