I'd like something like this. The layer-snap's upgrade-hook cycle calls code[1] that checks for a non-zero resource, and then checks whether that resource has changed. I bet many charmers do this, and it would be useful to have a decorator that does it for us.
[1] https://github.com/stub42/layer-snap/blob/master/lib/charms/layer/snap.py#L53 On Tue, Sep 26, 2017 at 9:51 AM, James Beedy <[email protected]> wrote: > That totally does! This sounds like a great path forward that would allow > us to eventually migrate away from having 'upgrade-charm' fire when a > resource is attached, while maintaining backward compat for the charms that > use it until its deprecated. > > Well .... I didn't mean to just imply that things should change to this ^ > way, but it seems sensible. Possibly we could have more of a conversation > around this? > > ~James > > > > On Tue, Sep 26, 2017 at 12:41 AM, Merlijn Sebrechts < > [email protected]> wrote: > >> Does a `resource.changed` flag address your needs? That should be >> possible to implement in charms.reactive, I think. >> >> 2017-09-24 17:53 GMT+02:00 James Beedy <[email protected]>: >> >>> How do people feel about splitting the upgrade-charm hook into multiple >>> hooks to facilitate better resource management? >>> >>> What I'm thinking would be super helpful would be to have the >>> upgrade-charm hook still active for charm upgrades, and have separate hooks >>> or flags that would indicate resource upgrades. >>> >>> I'm thinking something like: >>> >>> 'juju attach myapp myresource=myresource.file' >>> >>> Would cause the 'upgrade-resource-myresource' hook to become active on >>> instances of 'myapp'. >>> >>> I feel that having this affinity from resource -> >>> resource-upgrade-<resource-name> hook would be a huge win for resource >>> management. >>> >>> Thoughts? >>> >>> >>> >>> >>> -- >>> Juju-dev mailing list >>> [email protected] >>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailm >>> an/listinfo/juju-dev >>> >> >> > > -- > Juju mailing list > [email protected] > Modify settings or unsubscribe at: https://lists.ubuntu.com/ > mailman/listinfo/juju > > -- [email protected]
-- Juju mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju
