Sounds like a plan. I'm hoping the amount of functionality that needs to end up in Base is pretty small.
On Monday, January 13, 2014 1:54:45 PM UTC-5, Stefan Karpinski wrote: > > Ok, game plan: > > 1. Merge https://github.com/JuliaLang/julia/pull/4866. This means > building julia will download and build libgit2 as a dependency (and > submodule), but initially we won't be using it for anything. > 2. Modify LibGit2 to use the libgit2 that ships with Julia. > 3. On a branch, port Pkg to use LibGit2, assuming the package is > already installed. At this point the branch exists in strange state where > you have to install the LibGit2 package in order to use Pkg – which you > can't do without Pkg. This state of affairs is transient. > 4. Once it becomes clear what subset of LibGit2 is necessary for Pkg, > refactor so that that core part of LibGit2 lives in Base, while the > LibGit2 > package layers the rest of the LibGit2 interface on top of that bare > minimum. After these changes, it will no longer be necessary to have > LibGit2 installed to use Pkg. > 5. Merge the branch, celebrate. > > Sound reasonable? > > On Monday, January 13, 2014, Isaiah Norton wrote: > >> Yes, just shared a download link with you. >> >> >> On Mon, Jan 13, 2014 at 11:04 AM, Jake Bolewski >> <[email protected]>wrote: >> >>> Thanks John. >>> >>> You're on OSX right? I don't know how much of a pain it would be to >>> install the libgit library but it would be great if you could try to run >>> the tests to see if any changes need to be made there. I don't have access >>> to a mac so this would be a big help. >>> >>> On that note, does anyone have a 3.0 prerelease Window's build I can use >>> for testing? >>> >>> Best, >>> Jake >>> >>> >>> On Sunday, January 12, 2014 6:29:27 PM UTC-5, John Myles White wrote: >>> >>>> This seems really awesome. Amazing work, Jake! >>>> >>>> — John >>>> >>>> On Jan 11, 2014, at 9:56 PM, Jake Bolewski <[email protected]> >>>> wrote: >>>> >>>> > Link https://github.com/jakebolewski/LibGit2.jl >>>> > >>>> > On Sunday, January 12, 2014 12:55:27 AM UTC-5, Jake Bolewski wrote: >>>> > Hi everyone, >>>> > >>>> > I've been working on LibGit2 bindings for julia over the past month >>>> or so, steadily porting over the the test suite from Ruby's rugged >>>> library. >>>> > Allmost all of the tests have been rewritten and are now passing. >>>> Most of the testing has been done on the development branch of the libgit >>>> library and on Linux. >>>> > Please run the test suite and submit an issue if (when) it breaks on >>>> your system. >>>> > >>>> > Hopefully once this matures some more it will enable Pkg to be be >>>> rewritten using libgit. >>>> > See: https://github.com/JuliaLang/julia/issues/4158, >>>> https://github.com/JuliaLang/julia/pull/4866 >>>> > >>>> > If you have any spare cycles please help! The api could be >>>> refactored quite a bit. Hopefully this is a good base to work from. >>>> > >>>> > Best, >>>> > Jake >>>> > >>>> >>>> >>
