Hi, Siddhant Thanks for working on this. I took a brief look of the source codes. Here are several comments:
1. It is the convention of Julia package to have a suffix *.jl* in the repo name. For example, you can have your github repo named ``UCLMLRepo.jl``. 2. It seems that the blocks within if-end and for-end are not properly indented (at least that's what I see here: https://github.com/siddhantjain/UCIMLRepo/blob/master/src/UCIMLRepo.jl#L13-L15). Try using 4-spaces indentation (instead of using tab). 3. Please use all lower cases for function names. The UCLRepoData( ...) function is confusing, as people would think it creates an instance of a type UCLRepoData, but it turns out not the case. Use camel case only for types and constructors. 4. The function parse_rcvd_info seems to print things, but returns nothing. 5. You refer to https://github.com/johnmyleswhite/RDatasets.jl for reference as to what a data set package might look like. Dahua On Wednesday, March 19, 2014 1:50:58 AM UTC-5, Siddhant Jain wrote: > > Hello! > > I have written a small package that allows for easy access and download > for datasets from UCI ML repository from within Julia into a DataFrame. > > Please have a look at it here: https://github.com/siddhantjain/UCIMLRepo > and give your feedback. > this is my first package so code can contain bad practice. I am looking at > other packages to get a sense of coding guidelines. > > I am interested in working for Julia in GSOC on the project 'Standardised > Dataset Packaging' and figured that writing a small package like this one > will help me get a better feel for writing packages for Julia. As the > deadline is just a couple of days away, I will start working on the > application as soon as possible and give it to potential mentors for a > review before the final submission. > > Could you someone please direct to me possible mentors? That way I can > discuss my application with just them and not flood the mailing list with > content that doesn't concern everyone. > > Thank you! > > Sincerely, > > Siddhant Jain > Birla Institute of Technology and Science, Pilani > India > > > P.S: If you are using a pre-release version (0.3 and above) of Julia, you > might encounter a HUGE set of warnings. I am trying to figure out the > reasons behind that. Will file a bug in due time if I am not able to solve > the issue. > However, these warning do not affect the working of the functions in > package. > >
