Hi Dmitry,

Thanks for announcing this!  I have used other key value stores on
projects, but I had never heard of KyotoCabinet. I'll have to check it out
now.

With a quick look, you code seems really clean.  The only thing that caught
my eye were your conversion to Uint for your constants. In Julia,

   convert(Uint, 1<<4)

can be written as

   0x1 << 4

Would you consider submitting this as a package, so it gets listed on
pkg.julialang.org and benefits from daily testing, and so that people can
find and try it easier?  The only change needed would be to rename the
package to KyotoCabinet, to match Julia package naming conventions.  See
http://julia.readthedocs.org/en/latest/manual/packages/ for more details.

Cheers,
   Kevib

On Friday, August 29, 2014, Dmitry Semyonov <[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:

> Hi all,
>
> I used KyotoCabinet <http://fallabs.com/kyotocabinet/> key-value storage
> in some of my Python projects, but couldn't find bindings for Julia. So I
> wrote something by myself. Hope it might be useful for someone else.
>
> Here is the source: https://github.com/tuzzeg/kyotocabinet.jl
>
> I am pretty new in Julia world, so if you have comments, code
> style/performance/design suggestions - I'd love to hear them.
>
> Cheers,
> Dmitry
>

Reply via email to