Hi Petr, I've done a 1st pass over JFinEALE.jl attempting to make minimal changes to the current structure.
For now the changes are avaliable in a (forked) github repository: https://github.com/goedman/JFinEALE.jl A few questions for a next pass: 1. I'm not sure I like to the levels of modules. This way a user has to know which 2nd level modules he/she should be using. Is there a reason you choose this setup? I typically prefer that the end user only needs a single 'using JFinEALE' statement. That requires some additional work, so wanted to have your views first before going there. Even then there are a few ways of how we can implement that, e.g. remove the 2nd layer of modules (make them all methods) or export more in JFinEALE. 2. For now I've added *.vtk to .gitignore. I prefer to have examples in their own directory and .vtk files can be stored there as well. Do you have a preference? 3. I have not Julia-normalized the Paraview paths lines in the examples. In most cases, for now, I've made them @windows_only ... We could check if Paraview is available, e.g. by looking for an environment variable or a definition in .juliarc.jl. 4. I do export 'phun' right now in JFinEALE. Let me know what your preference is. You should be able to Pkg.clone("https://github.com/goedman/JFinEALE.jl";) after Pkg.rm("JFinEALE") first. Once this version is installed, you can run Pkg.test("JFinEALE"), it should run all examples (twice in fact, to see if first time is slower than subsequent times). Or we could make this version a branch or I could generate a PR first. Regards, Rob J. Goedman [email protected] > On Jan 11, 2015, at 9:30 AM, Petr Krysl <[email protected]> wrote: > > Sounds like a good idea. > P > > On Saturday, January 10, 2015 at 7:23:25 PM UTC-8, Rob J Goedman wrote: > Petr, > > Would you like me to prepare a simple pull request tomorrow? > > Regards, > Rob > > Sent from my iPhone > > > On Jan 10, 2015, at 6:22 PM, Petr Krysl <[email protected] <javascript:>> > > wrote: > > > > Hello everybody, > > > > I wonder if I could get some advice on how to structure a package? I could > > see how the SRC and TEST folders had a place in the package structure, > > but so far I could not discern a systematic way for access to examples that > > use the package. In particular, when I create a package (clone()),, and > > the package has an EXAMPLES folder, none of the stuff in that folder is > > actually visible at the REPL... > > > > How should this be handled? > > > > Thanks, > > > > P
