Hi Andrei, just a general note, unless someone is actually interested in using your code, a code review might be too much to ask of people. Thus the lack in responses. See: https://groups.google.com/forum/#!searchin/julia-users/karpinski$20reivew/julia-users/C5cVjAuGA8U/HLV5rAjIuLMJ
The way to get most feedback, is to condense your problem into a small snippet which can just be run with copy-paste (you're gists fails there) and ask something specific. An exception seem to be questions of the kind "I ported this from C/Fortran/... and it is 100x slower, where did I go wrong", which seem to regularly attract much feedback. I didn't look into the code in detail: > It's the first time I try to use Julia constructors properly (or > improperly?!) so I need your opinion on a couple of points. Use of constructors seem to be fine. > 1. On Julia's IRC channel I was told that using AbstractArray instead of > e.g. Matrix/Vector might yield a performance boost - is that the case? No, I don't think so. Did you read the Performance section of the manual? There it also tells you how to profile your code. > 2. Can you spot any major performance killers in my code? > 3. Coming from Python, I am used to things like enumerate etc, but perhaps > that is not very "Julian"? :) So this last aspect concerns more the coding > style, I guess. Using enumerate is totally fine. Just don't do object-oriented programming. Looks all good to me!
