So I have a PR
https://github.com/JuliaLang/julia/pull/16523

I get an error on AppVeyor build which I don't understand. Any tips, or 
missed documentation is greatly appreciated! My GitHub kung-fu is fledgling 
at best.

On Saturday, May 21, 2016 at 11:33:20 AM UTC-7, Gabriel Gellner wrote:
>
>
>
> I think it's an error.  The method definition should probably just be:
>>
>> linreg{T<:Number,S<:Number}(X::AbstractVector{T}, y::AbstractVector{S}) = 
>> [ones(T, size(X,1)) X] \ y
>>
>> which will allow it to work for X and y of different types.
>>
>> Is using the more specific typing (<: Number) the current best practices? 
> I notice a lot of the methods in linalg/generics.jl just check for 
> AbstractVectors etc without requiring numeric types even though that would 
> be the more correct check.
>  
>
>> A PR (pull request) with a patch and a test case would be most welcome.
>>
> On it! Taking me a bit of sweat to figure out the build process and github 
> stuff but once I have that all sorted a PR will be submitted. Thanks for 
> the quick response. 
>

Reply via email to