Hi Sascha, Great work! You have found the cause of another annoying slowdown. I first noticed this doing the burlulc benchark with Colour Theming. It really needs to be fixed. I noticed that it is fixed in Kosmo already, however their model is probably different.
Fixing BasicStyle to use a more lightweight fill pattern construction method would be a good idea. I'm not sure why we can't just have every new instance point to the same default copy stashed somewhere. regards, Larry On 6/5/07, Sascha L. Teichmann <[EMAIL PROTECTED]> wrote: > Hi together! > > I was wondering why it takes so long to enable > Colour Theming when working with layers with a > higher number of features. > > If you open the "Changes Styles", choose tab > "Colour Theming" and check "Enable colour theming". > > If I do this with a 36,000+ polygon shape file it > takes about 24(!) seconds before I can go on. > (AMD 1.2 GHz/Athlon-T-Bird, GNU/Linux, Java6) > > I profiled it a bit and found out that almost > the whole time is spend with constructing simple > BasicStyle [1] objects. In this concrete case the problem > can be solved if you reuse already created BasicStyle objects. > After this fix the 24 secs go down to 0.001 secs!!! > I can send a patch which does this. > > The main problem is the expensive construction of > the BasicStyle objects. When they are created > a WKTFillPattern is created too. Always! Even if it > is not used! The construction of such a fill pattern > involves a lot of string parsing with a WKTReader, > math, etc. A little bit heavy weighted in my opinion. > Jon has a comment in BasicStyle that says it is done > to make the GUI happy. This has to be done better! > Because BasicStyle objects are constructed very often > in *JUMP I cannot estimate the overall performance > lost coming with this issue. > > Comments? > > - Sascha > > [1] com.vividsolutions.jump.workbench.ui.renderer.style.BasicStyle > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > -- http://amusingprogrammer.blogspot.com/ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
