I've added a new interface and deprecated the old one.

I was thinking that we could clean up this code a little, at the moment
there is hard coded implementations for layers and WMS layers. We could
change this to use a factory approach by creating implementations for these.

There are actually a whole bunch of places we could do this including
the tree view panel.

Any objections if I gradually move over to using a factory based approach?

Paul

Stefan Steiniger wrote:
> Hei Paul,
>
> is it possible to restore the old method? - i.e. to have the method 
> twice with different params? Because breaking old code is not what I 
> would like to see during the core development.
> You could use then the new method while the old one is still working for 
> others.
>
> If we do such core changes I would require that a "deprecated" tag 
> should be set first at least for the 1-2 years.
>
> About updating the pirol plugins:
> It is currently not possible. As far as i am informed the Pirol project 
> will get a new programmer not before March 08. And they maintain the 
> sources on their own (but they are provided with the plugins).
>
> cheers from Germany,
> Stefan
>
> Paul Austin schrieb:
>   
>> Uwe,
>>
>> I made a change to the API to pass in the LayerViewPanel so that the
>> renderers can get access to it.
>>
>> If you can update the pirol plug-ins to have that additional parameter
>> that would be great.
>>
>> Paul
>>
>> Uwe Dalluege wrote:
>>     
>>> Hi,
>>>
>>> when I use the PIROL rasterImage-PlugIn (rasterImage.jar)
>>> with OJ-NightBuild I receive the following error:
>>>
>>>
>>> java.lang.AbstractMethodError: 
>>> de.fhOsnabrueck.jump.pirol.utilities.RasterImageSupport.RasterImageLayerRendererFactory.create(Ljava/lang/Object;Lcom/vividsolutions/jump/workbench/ui/LayerViewPanel;)Lcom/vividsolutions/jump/workbench/ui/renderer/Renderer;
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.renderer.RenderingManager.createRenderer(RenderingManager.java:266)
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.renderer.RenderingManager.render(RenderingManager.java:191)
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.renderer.RenderingManager.render(RenderingManager.java:185)
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.renderer.RenderingManager.renderAll(RenderingManager.java:158)
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.LayerViewPanel.repaint(LayerViewPanel.java:420)
>>>     at 
>>> com.vividsolutions.jump.workbench.ui.Viewport.update(Viewport.java:111)
>>>     at com.vividsolutions.jump.workbench.ui.Viewport.zoom(Viewport.java:260)
>>>     at 
>>> de.fhOsnabrueck.jump.pirol.plugIns.PirolRasterImage.RasterImagePlugIn.addImage(RasterImagePlugIn.java:116)
>>>     at 
>>> de.fhOsnabrueck.jump.pirol.plugIns.PirolRasterImage.RasterImagePlugIn.execute(RasterImagePlugIn.java:218)
>>>     at 
>>> com.vividsolutions.jump.workbench.plugin.AbstractPlugIn$1.actionPerformed(AbstractPlugIn.java:130)
>>>     at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
>>>     at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
>>>     at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
>>>     at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
>>>     at javax.swing.AbstractButton.doClick(Unknown Source)
>>>     at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
>>>     at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown 
>>> Source)
>>>     at java.awt.Component.processMouseEvent(Unknown Source)
>>>     at javax.swing.JComponent.processMouseEvent(Unknown Source)
>>>     at java.awt.Component.processEvent(Unknown Source)
>>>     at java.awt.Container.processEvent(Unknown Source)
>>>     at java.awt.Component.dispatchEventImpl(Unknown Source)
>>>     at java.awt.Container.dispatchEventImpl(Unknown Source)
>>>     at java.awt.Component.dispatchEvent(Unknown Source)
>>>     at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
>>>     at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
>>>     at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
>>>     at java.awt.Container.dispatchEventImpl(Unknown Source)
>>>     at java.awt.Window.dispatchEventImpl(Unknown Source)
>>>     at java.awt.Component.dispatchEvent(Unknown Source)
>>>     at java.awt.EventQueue.dispatchEvent(Unknown Source)
>>>     at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
>>>     at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
>>>     at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
>>>     at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
>>>     at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
>>>     at java.awt.EventDispatchThread.run(Unknown Source)
>>>
>>>
>>> Who can help?
>>>
>>> Regards
>>>
>>> Uwe
>>>
>>> -------------------------------------------------------------------------
>>> SF.Net email is sponsored by:
>>> Check out the new SourceForge.net Marketplace.
>>> It's the best place to buy or sell services
>>> for just about anything Open Source.
>>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>>> _______________________________________________
>>> Jump-pilot-devel mailing list
>>> Jump-pilot-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>>   
>>>       
>> -------------------------------------------------------------------------
>> SF.Net email is sponsored by:
>> Check out the new SourceForge.net Marketplace.
>> It's the best place to buy or sell services
>> for just about anything Open Source.
>> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
>> _______________________________________________
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
>>     
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services
> for just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>   


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to