Stefan Steiniger a écrit :
> thank you Michael for the improvements!
>
Only small modifications, but the following one that I'd like you and
others validate (included in nightly build).
Before the fix, in-memory layers created by plugins are simply ignored
when user quit the application.
One of my co-workers recently lost a lot of work because he thought that
"save the project as" had saved all the newly created layers !
I added a one-liner in Layer constructor marking all new Layers as
"modified", so that user is warned when he wants to quit.
Layers created by loading a shapefile are not concerned thanks to a
special instruction making it unmodified at creation time.
I did not test what happens with other formats, databases, or wms access.
> @all: BTW: I introduced the new Tools/Statistics menu and moved all 3
> stats functions there. I also i18n'ed my last commits.
>
Thanks for all the work,
> I realized that I also need to port some some more image functions from
> Pirol - i.e. the layer context menu functions. Otherwise such layer can
> be added only programatically and can not be changed or removed...
> I was thinking that we should then introduce a new Load "Sextante Raster
> Image" icon in the file loader (...if I find out how to...)
> Let's see when I find the time.
>
I noticed that we miss some policies to keep code consistent :
- internationalized strings are not always declared the same way (in
last plugins, they seem to be initialized as static class attributes,
then again in the plugin initializer. I'm not sure what the best
practise should be
- menu items opening a dialog box should end by ... Sometimes, the
ellipse is added by the plugin itself, sometimes it is included in the
properties file (I'd rather first solution is better)
- every enableCheck String is defined 2 times in the properties file.
One time with a short key and a {0} in the key and the other time with a
complete key and no {} in the key. I did not check which one is mostly
used in the source.
- we should avoid accented character in the source...
...
I'm not the best expert to write a guideline, but I can try to start it
so that we can discuss about the best practises.
Michaël
> stefan
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
> -Strategies to boost innovation and cut costs with open source participation
> -Receive a $600 discount off the registration fee with the source code: SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
>
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
