Hei, finally I committed the patch. Was easy to do. I excluded the the change for the LayerPropertiesPlugIn, and did what Volker suggested (can somebody check this? - is the separate commit no. 1885).
If you have more changes let us know. And I think, as you seem to be pretty proficient, after one more round of accepted patches, we could give you commit access - if you wish. danke! - and sorry for being so slow. stefan [email protected] schrieb: > Hello Michaël, > > - DeeChangeStylesPlugIn: Is e.g. in the popupMenu of the LayerNamePanel > as "Change Styles". I expect that the method wouldn't change anything > when the dialog was canceled. As far as I can see most things which are > done before the dialog is visible are reading/initializing-stuff . * > > - CopyStylesPlugIn: It's in the same popupMenu as DeeChangeStylesPlugIn. > You can copy the style of one layer and paste it with > PasteStylesPlugIn. Its execute method just clones the styles and put the > copy into a local static variable. > > - LayerPropertiesPlugIn: Same popupMenu: Shows the properties of the > selected Layer. I've just rechecked this plugin and saw that the 2nd tab > changes the "Proportional-Transparency-Adjustment". So as this plugin > does changes, I have to change athe patch. The new code should be at the > end of the execute-method and should be something like: > > if ( !styleChanged /*existing variable of this class*/) > reportNothingToUndoYet(context); > > I'll create the new patch on monday. > > Regards > > Volker > > * it saves the last used tab , even if canceled, but I guess that's not > a reason to truncate the undo-history > > Michaël Michaud schrieb: > > Hi, > > > > I'm not familiar with this part of the code. Just can say it "looks" ok. > > If you can say how it is supposed to work before/after the change, I'll > > give a try after the commit. > > > > Thanks, > > > > Michaël > > > > [email protected] a écrit : > > > >> Hi, > >> > >> attached is a patch with 4 tiny change-suggestions: > >> > >> - reportNothingToUndoYet for > >> - CopyStylesPlugIn > >> - LayerPropertiesPlugIn > >> - DeeChangeStylesPlugIn (unless dialog.wasOKPressed() ) > >> - Constructor of DrawConstrainedLineStringTool as proctected which > >> gives me the possibility to overwrite it. > >> > >> Hopefully there are no concerns and the patch was created correctly ( > >> not sure if its necessary to include the full path e.g.) . > >> > >> Have a nice weekend, > >> > >> Volker > >> ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Jump-pilot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
