Hi Giuseppe,

Thanks for improvments proposals.
Proposal 1 seems to be a small change and I'll try to do it.
Proposal 2 is a more important change even if source code partially exists in Pirols plugins. Hopefully, Mohammed , Alberto, or maybe someone else will have time to investigate.

I suggest you keep track of this proposal and of the bug you found in OpenJUMP bug tracker (there is a place for Feature Request and another for Bug Tracking). It is a list I go through when I have some free time.

Michaël

Le 08/02/2011 10:16, Giuseppe Aruta a écrit :
Hi Michael,
just a couple of issues and proposals for further discussions:

- Proposal 1 -
Move "Toogle visibility" to the bottom of menu
In sextante raster image menu the tool "Toogle visibility" is located at the top of the menu. I experience that if I click on a Sextante visible file on the layer list, this tool inadvertently actives itself and the file becomes not visible. Can we move this tool at the bottom of the popup menu? It would be more pratical and similar to the other "Toogle visibility" tool in vector file popup menu. I did this on my prebuild version of OJ only modifying LoadSextanteRasterImagePlugIn.

- Proposal 2-
x,y max, min can be useful in sometimes, but I image that an extra menu where people can write the worldfile od of the loaded file would be better. This could be useful to set position of the file and any possible x,y rotation (see hidden tool)

- Hidden Tool -
Using "Warp image to fence"
This is an hidden and useful tool in ex-pirol functionalities.
Actually, using this tool together with Edgar's CTS tool, I can make reasonable re-projections of raster files. The only limit is that the "reprojection" works only with y and x translations and no rotations. I In many case it is not useful, for instance reproject from geografic to cartesian where there is always a rotation of the axis. But in other situation is extremely useful within cartesian reprojections: it works very well when I have to reproject between WGS84 and any Italian local CRS (Gauss-Boaga, etc) which I cam configure with Edgar's CTS, even better than standard GIS like GvSIg. Within the limitations of "rotation", it is possible also to "georeference" raster files. In this case it requires the usage of Warping tools in stead of CTS. Mohammed, this could be a base to study a "reproject" and "georeferecing" tool for Openjump which do not invoke other libraries except java ones (no gdal or similar) and using only embedded libs.
I can write down more details about this hidden tool if needed.

- bug or strange behavior-
in Sextante popup menu there is a "Save raster to image" tool. This tool has a random strange behaviour:

1)  using on any color image,
It works fine and the saved file can be reopen with no problems.

2) using on a TIF file black and white file, where white is a NO-DATA area. it saves the file as a negative. When I try to reload the saved file, it is not displayed.

3) Using on a grid file (tested on TIF or ASC). The file is saved with 0 byte dimension and
It shows this error message:
-------------------------------------------------------------
ava.lang.NullPointerException
    at org.libtiff.jai.util.PropertyUtil.getString(PropertyUtil.java:54)
    at org.libtiff.jai.util.JaiI18N.getString(JaiI18N.java:28)
at org.libtiff.jai.codecimpl.XTIFFImageEncoder.getImageFields(XTIFFImageEncoder.java:246) at org.libtiff.jai.codecimpl.XTIFFImageEncoder.encode(XTIFFImageEncoder.java:142) at org.openjump.core.ui.plugin.layer.pirolraster.SaveRasterImageAsImagePlugIn.execute(SaveRasterImageAsImagePlugIn.java:135) at com.vividsolutions.jump.workbench.plugin.AbstractPlugIn$1.actionPerformed(AbstractPlugIn.java:130) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
    at javax.swing.AbstractButton.doClick(AbstractButton.java:357)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1223) at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:1264)
    at java.awt.Component.processMouseEvent(Component.java:6267)
    at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
    at java.awt.Component.processEvent(Component.java:6032)
    at java.awt.Container.processEvent(Container.java:2041)
    at java.awt.Component.dispatchEventImpl(Component.java:4630)
    at java.awt.Container.dispatchEventImpl(Container.java:2099)
    at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
    at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
    at java.awt.Container.dispatchEventImpl(Container.java:2085)
    at java.awt.Window.dispatchEventImpl(Window.java:2478)
    at java.awt.Component.dispatchEvent(Component.java:4460)
    at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
_____________________________________________________

Point 1 is probably the heritage of original Pirol raster tool. But point 2 and 3 came out probably when raster pirol was extended to other image format files (grid etc).
It would be interesting to correct if possible.
In all the 3 case, under Ubuntu, when I save the file it shown the message on bottom bar "file not found", the TFW file is correctly saved.

regards

Peppe




------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb


_______________________________________________
Jump-pilot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Jump-pilot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to