Hi Geoffrey,

OK, when you are happy that there are no more bugs I will release the new version (and code)
Thanks, it works fine for me now.

Later, I'll send you a language file for vertex plugin, but this is another jar, so this is just for information.

Thanks for all,

Regards

Michaël




Geoff

On 14/07/2011 4:11 AM, Michaël Michaud wrote:
Hi, Geoffrey

Thanks a lot for all your efforts,

I'll test your improvements soon and let you know.

Michaël
Dear Michael

Thanks for the feedback. I am attaching revised version:

   1. The problem with the number format could be solved nicely with
      some effort, but I have simply removed the grouping separator
      (a comma in English).  There is obviously a problem with
      European decimal formats.  I think this is the problem, please
      test again.
   2. The titles for the various renderers have changed over time -
      also their "meaning".  In earlier attempts I was testing 4
      different renders that were called "Quality" "Accurate" etc,
      but these have been replaced by three "ISA, Core and External"
      - with the user to decide which gives the best results.
   3. I now understand your problem with the name of the JAR - yes
      it cannot be changed without changing the code.  Again this
      can be fixed, but I do not have the time at the moment.
   4. The typo in the language files fixed
   5. A new French language file installed.

Hope this is now OK for you.

regards

Geoff

On 11/07/2011 6:29 AM, Michaël Michaud wrote:
Hi Geoff,

Thanks a lot for improvements !

   1. The scale field now checks for numeric values with spaces,
      and attempts to resolve a reasonable number, so "1 234" and
      "1,234" converts to "1234".  Please let me know if this
      causes any other problems with your decimal point/separator
      values.


This one is not fixed for me. To reproduce the problem, set locale to french/France, open the main printer dialog (I get a scale of "2 897" for example), and click in the "fit to page" checkbox.
I get an "Error in the scale field" error.
If I change to english/Australia locale, I get the scale as 2,897 (instead of 2 897) and there is no more error.
If I manually change 2 897 to 2897, It also works fine.
Maybe this example can help : http://www.exampledepot.com/egs/java.text/Numbers.html

   1. The <Window Close> button now operates the same as the
      <Cancel> button.

Fixed, thanks.

   1. PrinterPlugin tooltip is now internationalized

Fixed, thanks.

   1. The title of the <About> dialog is now internationalized.

Fixed, thanks

   1. The "Quality" word in the Help dialog should simply be
      removed from the language file
      (JumpPrinter.HelpDialog.Message7).  In English I have
      changed this to "Options ....".  I have not changed the
      other language files.

OK, what I meant was that "Precision" and "Quality words used in "JumpPrinter.Setup.Quality" and "JumpPrinter.Setup.Message7" were probably refering to old PrinterSetUp String [] qualityItems = {"OJ Quality Renderer", "OJ Accurate Renderer", "External Renderer","SkyJump Renderer"};
but make less sens for the user now that renderer are called
String [] qualityItems = {"ISA Renderer", "Core Renderer", "External Renderer"}; Not sure if terms Precision/Quality must be removed from language file or add to renderer names...

   1. [..] around "Furniture"  in Help dialog now corrected.

Fixed, thanks

   1. Save Image dialog, "Size" is now internationalised

Fixed, thanks

   1. Your French language file is now included in the jar

Great, thanks

   1. <Note> Panel -- and ++ buttons are now internationalised, In
      English I have named these "Del" and "Add".  I have
      attempted the translation into Italian, German and French
      (excuse my poor language skills).  Note that the layout of
      the dialog is sensitive to word length - but you can always
      put "--" and "++" in the language file.

Fine, thanks

   1. The package com.cadplan.fileio was in both jars (this is not
      good - I know).  Generally it did not cause problems -
      but!!!  For JumpPrinter I have renamed this package to
      com.cadplan.fileioA - this should solve the problem for the
      moment.

Sorry for my bad diagnosis. The problem is still there (if I change the jar name to JumpPrinter-1.77.jar, I get an exception).
Now, I think this is because application name in PrinterPlugIn...
//PrinterPlugIn
IconLoader loader = new IconLoader(dirName,"JumpPrinter");
// is used as jarname in IconLoader
filename = "jar:file:"+wd+"/"+appName+".jar!/"+"Resources/"+name;

OK, this problem is not a big issue as I have not to rename the jar file Just let you know why I could not do it and let you decide if it is worthwhile fixing it.

Also there is a typo in language file with the key
JumPrinter.OkToPrint which should be JumpPrinter.OkToPrint (with 2 'p') as in the source code

Attached, the french file with a few typo fixed.

Best regards,

Michaël

Please let me know how you get on.

thanks

Geoff



On 3/07/2011 6:34 PM, Michaël Michaud wrote:
Hi Geoff,

I just have translated PrinterPlugIn to french.
Please find the properties file attached to this mail.
I'm on the way of including it in OpenJUMP 1.4.1-s distribution.

It gave me the occasion to appreciate the excellent work you did for this plugin.
I realized that I did not know 10% of its capabilities :-) .

Here are a few points where, in my opinion, it coud be improved :

The only bug I found is related to the scale displayed in the main menu. When the dialog is opened, displayed scale number uses the local (ex. Scale 1: 2 983 with my french configuration), but it cannot read it back because of the space between thousands and units.
It throws the same error as when a bad number is manually entered.

The cancel button of the main dialog works fine (simply closes the dialog box) I would have expected the same behaviour when I use the dialog close button (upper right corner),
but instead, it opens the Printer dialog box.

Other remarks are small ui improvement suggestions (sorry if I missed some points) :
- PrinterPlugIn button tooltip is not yet internationalized
- Button "About" is internationalized, but not About dialog box title - Renderer chooser is refered as "Quality" option in the Help dialog box, but has no title in the main configuration dialog box - In the Help dialog, brackets around Furniture Dialog are not closed - In the Save Image dialog box, "size" option is not internationalized - IMO, in Note panel of Furniture dialog box, an Add/Remove internationalized button would be better than -- and ++

Thanks again for this excellent plugin.

Michaël


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


-----
No virus found in this message.
Checked by AVG -www.avg.com
Version: 10.0.1388 / Virus Database: 1516/3741 - Release Date: 07/03/11

--
Dr Geoffrey G Roy
Cadplan
129 Gloster Street, Subiaco WA 6008
Tel: (08) 9381 4870  Fax: (08) 9382 4459
Email:ge...@cadplan.com.au
http://www.cadplan.com.au

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel



------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 10.0.1388 / Virus Database: 1516/3757 - Release Date: 07/10/11


--
Dr Geoffrey G Roy
Cadplan
129 Gloster Street, Subiaco WA 6008
Tel: (08) 9381 4870  Fax: (08) 9382 4459
Email:ge...@cadplan.com.au
http://www.cadplan.com.au

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel



------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


No virus found in this message.
Checked by AVG - www.avg.com <http://www.avg.com>
Version: 10.0.1390 / Virus Database: 1516/3763 - Release Date: 07/13/11


--
Dr Geoffrey G Roy
Cadplan
129 Gloster Street, Subiaco WA 6008
Tel: (08) 9381 4870  Fax: (08) 9382 4459
Email:ge...@cadplan.com.au
http://www.cadplan.com.au

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev


_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to