On 18.01.2012 23:25, Michaël Michaud wrote: > Hi Ede, > >>> you can add the exclusion to the nosrc configuration >>> of maven-jar-plugin in pom.xml ;) >>> i'll doublecheck your change then > > done, thanks to check,
it's essentially a mvn clean package -P release and checking that the resulting zip distro still works ;) > > Could you explain to me how the build system knows > if it must execute the nolang or the nosrc configuration. > I did not find reference to these config elsewhere in the pom... it doesn't it compiles complete and packages the jar three times in one flavor each > Another remark after this little travel through the pom : > Isn't it unsafe to compile all the sources and to > filter afterward (when the jar is assembled) ? > Seems to me that it would be more safe to filter sources > at compile time (and get a compilation error in case of > inconsistent filtering). before we only filtered source or lang.properties.. they wouldn't have lead to a compile error nowhere ;) > What do you think ? you're right, your filtering classes later is definitely error prone. i am also not sure if there might not be a *Test.class that is unlucky to be called like that because somebody named her so. could you check if this condition currently matches only junit test classes? while we're at it i think we should rename those classes more clearer *JUnitTest.* maybe. ..ede ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
