On 11.11.2012 16:20, Michaël Michaud wrote: > Hi >> sorry Mike.. that was too optimistic.. haven't come around so far to make >> the zip loading more robust, will have a look at it now. > Much work for a corner use case.
well, the whole zip file opening is a corner use case ;).. but, in terms of user experience i vote: either fully or not at all. i think silently ignoring files is not what a user'd expect. >> i actually also wonder what we need the dummy reader for, if user is >> informed that some of the files couldn't be read via output window? > Only useful if the user want to skip xml (or txt) files embeded in a zip > file. > In this case, I think the dummy-driver solution is cleaner than the one > where > the user has to choose a driver which does not match the file format, then > making the driver silently fail. > Drawback is that the driver is made available in normal case (non zipped) > which is useless and may confuse the user. > > Anyway, if you have a good solution before 1.6 final, I'm open to a change. let me try to disable dummy reader, but add it only to the list offered for compresses archives. this would unintentionally also open the possibility to selectively open files from archives. we should definitely rename the reader to IgnoreFileReader btw.. at least the speaking description in the gui, as this is what it does. > Thanks for the 1.6RC release, nP.. kinda push a button type of thing, since i set up the build scripts accordingly. ..ede > > Michaël > >> >> ..ede >> >> On 10.11.2012 17:05, SourceForge.net wrote: >>> Bugs item #3446420, was opened at 2011-11-30 13:13 >>> Message generated for change (Comment added) made by michaudm >>> You can respond by visiting: >>> https://sourceforge.net/tracker/?func=detail&atid=679906&aid=3446420&group_id=118054 >>> >>> Please note that this message will contain a full copy of the comment >>> thread, >>> including the initial issue submission, for this request, >>> not just the latest update. >>> Category: OpenJUMP - Menu - File >>> Group: None >>>> Status: Closed >>>> Resolution: Fixed >>> Priority: 5 >>> Private: No >>> Submitted By: michael michaud (michaudm) >>> Assigned to: Nobody/Anonymous (nobody) >>> Summary: Cannot open zipped shapefile containing also xml >>> >>> Initial Comment: >>> There is a problem with opening zipped shapefiles which are created with >>> ESRI products. ESRI is generating an additional .xml file that contains >>> some metadata about the shapefile. >>> >>> OpenJUMP File open mechanism believes that such shapefile in zip format >>> contains two datasets: shapefile and a XML file containing GML data. >>> OpenJUMP wants to open them both and insists user to point the >>> Input-Template-File for XML-GML. If the template is not given the file >>> open task will not go further. >>> >>> It is possible to fool OpenJUMP by telling that the .xml file inside the >>> zip is of type FME GML. In that case template is not asked and user can >>> load the shapefile. OJ is trying to open also the .xml metadata file which >>> is leading to an error. That does not harm the user really because the >>> shapefile opens as supposed. However, a novice OpenJUMP user cannot >>> discover the FME workaround. I consider this is a bug and user should have >>> an option "Do not open" for each recognised data type and for each >>> individual file found from the zip. >>> >>> -Jukka Rahkonen- >>> >>> ---------------------------------------------------------------------- >>> >>>> Comment By: michael michaud (michaudm) >>> Date: 2012-11-10 08:05 >>> >>> Message: >>> There has been a patch added by Ede to avoid the reading process to crash >>> if the xml reading fails, and a DummyReader added by Michael, which makes >>> it possible to set a Reader doing nothing for txt files and/or xml files. >>> >>> ---------------------------------------------------------------------- >>> >>> Comment By: Nobody/Anonymous (nobody) >>> Date: 2011-12-14 10:06 >>> >>> Message: >>> aCdffh <a href="http://thosbfkyqwwb.com/";>thosbfkyqwwb</a>, >>> [url=http://kizwtysqrvch.com/]kizwtysqrvch[/url], >>> [link=http://bhisbvdaltpa.com/]bhisbvdaltpa[/link], >>> http://ieyyqzmxbnio.com/ >>> >>> ---------------------------------------------------------------------- >>> >>> Comment By: michael michaud (michaudm) >>> Date: 2011-12-04 11:36 >>> >>> Message: >>> The modification of FileLayerLoader framework to add options is not a >>> simple task. >>> Wonder if we can just find a way to hide xml files in a zip containing >>> shapefiles, or always hide xml extension, as it is rarely used for gml >>> data. >>> >>> Anyway, if one want to add options, he will probably have to start from >>> org.openjump.core.ui.plugin.file.open.SelectFileLoaderPanel >>> >>> Michaël >>> ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ Jump-pilot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
