HI Michaël,
Yes, you are correct. I believe his is not the first time changes to
WMSLayer have affected SIDLayer. The original SIDLayer was a quick hack
that never got the refactoring it deserved. A common abstract parent is
probably the best practice.
However, I'm not sure why OJ still has the SIDLayer class since it was
incorporated into the last version of vividsolutions JUMP as
MrSIDReferencedImage (which is not descended from WMSLayer).. Is there
some feature of the original class that isn't in it? The java2xml perhaps
doesn't support saving to the project as well? I would like to test this,
but after an hour of trying I was unable to get a MRSID file to load in
OJ. There are many different wiki pages and readme files that contradict
each other, but I couldn't get any of them to work. I finally resorted to
debug and found the required path for the support executables, however I
got an NPE when I tried to open a SID file at
com.vividsolutions.jump.workbench.imagery.mrsid.MrSIDReferencedImage.getEnvelope(MrSIDReferencedImage.java:98).
This is the version that doesn't depend on WMSLayer so something else is
going on, but I don't have time right now to trace it down.
The path to the executables is: ../lib/ext/etc/ for mrsidgeodecode.exe
and mrsidgeoinfo.exe, and also a tmp folder for the tiles.
regards,
Larry
On Sun, Apr 14, 2013 at 11:34 AM, Michaël Michaud
<michael.mich...@free.fr>wrote:
> Hi Stefan, Larry
>
> While updating WMS code, I've found several patches from Stefan
> about SID Layer handling.
> Seems that SIDLayer inherits from WMS Layer, hence, patches
> have been added in WMS code to exclude cases where WMS Layers
> are instances of SIDLayer.
>
> The design seems error prone and probably currently buggy (and
> maybe more now that I've updated the code with WMS only in
> mind).
> Maybe the model would need an abstract parent for both WMS
> and SID Layer.
> The reason of sharing is probably the common createImage()
> method, but WMSLayer has also references to the WMService
> which have nothing to do with SID Layer (AFAIK).
>
> Agree with that ? Any comment ?
>
> Regards,
>
> Michaël
>
>
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
