Bugs item #3611503, was opened at 2013-04-21 10:34 Message generated for change (Comment added) made by andrei-n1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=679906&aid=3611503&group_id=118054
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andrei_n (andrei-n1) Assigned to: Nobody/Anonymous (nobody) Summary: Create polygon from closed area tool freezes OJ Initial Comment: Open Jump stops working when using the Create polygon from closed area to generate a sequence of polygons. The OJ window will collapse and the program can only be closed from the Task Manager (I'm using Windows 7). ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-25 04:51 Message: Hi Michaël, Unfortunately my bug wasn't fixed in r. 3530. I created a short screen capture film with the OJ crash: https://www.wetransfer.com/downloads/68d160c947902e20729799b9a0f75ee020130425114811/de362af00d3c090c84e2d0e22732135020130425114811/8fbf55 ---------------------------------------------------------------------- Comment By: michael michaud (michaudm) Date: 2013-04-24 13:34 Message: Hi Andrei, I tried a fix, but could not reproduce the bug, even before the fix. Let me know if according to your test, r3530 fix the problem. ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-23 14:38 Message: I'm now pretty sure there was no change which caused this error in rev. 1.5.1 or 1.5.2. I think I didn't get this error back then simply because I rarely used the tool. Your error behaves exactly like mine. I think it is related to my bug. In my case, after the first OJ collapse the error will reappear almost every time (just tested version 1.6.2 and the problem is still there). ---------------------------------------------------------------------- Comment By: michael michaud (michaudm) Date: 2013-04-23 13:02 Message: still can not reproduce the problem with your data and your instructions. Can you reproduce the problem with the current version (Nightly Build) ? The last fix on this plugin has been made a few days before 1.5.2 release, which means there is no reason that the plugin behaviour changed after 1.5.2. Oh, after many tests, I could get the following error. Now I get this error almost each time I click. But the window does not collapse. This is probably a concurrent issue. Don't know if it can be related to your bug. java.lang.NullPointerException at org.openjump.core.ui.plugin.edittoolbox.cursortools.FillPolygonTool.gestureFinished(FillPolygonTool.java:124) at com.vividsolutions.jump.workbench.ui.cursortool.AbstractCursorTool.fireGestureFinished(AbstractCursorTool.java:482) at com.vividsolutions.jump.workbench.ui.cursortool.MultiClickTool.finishGesture(MultiClickTool.java:248) at com.vividsolutions.jump.workbench.ui.cursortool.MultiClickTool.mouseReleased(MultiClickTool.java:139) at com.vividsolutions.jump.workbench.ui.cursortool.LeftClickFilter.mouseReleased(LeftClickFilter.java:93) at com.vividsolutions.jump.workbench.ui.cursortool.DelegatingTool.mouseReleased(DelegatingTool.java:105) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:273) Michaël ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-23 01:12 Message: 1. The problem is not related to the geometries. It is related to the warnings which appear when an area intended for polygon fill is not closed. 2. It happens after hitting the warning "cancel" button 2 or more times. After closing and restarting OJ, it will appear even when all the areas you want to fill are closed areas (the problem not dependent anymore on the appearance of the warnings) 3. I don't think it's necessary to send a dataset. Any simple dataset will do, even a layer with only 3 objects. You just have to try to fill a non-closed area several times and press cancel to the warnings. Just in case, here's a simple dataset: https://www.wetransfer.com/downloads/174d44f3cafe9fc6ac0772b02ad55d5220130423080815/2c9b65f165fbad1af50813ca9684d31520130423080815/5356f3. You can try filling any of the 3 bounded (but not closed) areas. 4. No, there;s no relation with the speed of the button click. I hope this helps. Please tell me if you need further information. ---------------------------------------------------------------------- Comment By: michael michaud (michaudm) Date: 2013-04-22 23:46 Message: I still could not reproduce it. Here are a few more questions : Do you think the problem is related to the geometries ? Does it happen with one polygon to fill only or ni several cases ? I would be interested in the dataset which makes the application freeze. Have you many features displayed when you click in the view (long task with the progress bar appearing on screen) ? Can you reproduce it with a small dataset ? Do you think that the bug is in relation with when you click on the button (clicking fast, before the previous task ends) or can you reproduce it when you click slowly ? Thanks for your help ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-22 15:40 Message: I forgot that only noded intersections are considered for determining the closed area. So the area from the screenshot below is actually correctly hinted as not being closed. But the relation betwen the warnings and the eventual OJ crash remains valid. ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-22 15:32 Message: I was happy too soon :( The problem is preceded by a ''clicked area is not closed'' warning. This error appears even when I want to insert a triangle-type polygon in a closed area. See this screenshot: http://img833.imageshack.us/img833/9694/polygonerror.png After retrying to insert the triangle several times and hitting cancel to the warnings OJ will freeze. Of course this also happens after genuine warnings are cancelled. Afterwards OJ will always freeze when generating several consecutive polygons from closed areas. The only solution is to reinstall the program. ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-22 14:42 Message: This is funny. I don't encounter this error anymore in the latest snapshot (rev. 3525). I think you fixed it Michael. Perhaps it was related to some other bug (?) It happened always after drawing more than 3-6 polygons. The 1.6.0RC1 release featured this issue, but some older version (either 1.5.1 or 1.5.2) was problem-free. ---------------------------------------------------------------------- Comment By: michael michaud (michaudm) Date: 2013-04-22 14:06 Message: Sorry, I've tested with several datasets and jre... but I cannot reproduce the problem. Is this a problem you encountered just once or did you get it several times ? ---------------------------------------------------------------------- Comment By: Andrei_n (andrei-n1) Date: 2013-04-21 11:25 Message: Sequence of polygons means creating polygons from closed area in a quick succession. There's no error message and I can't obtain any log output. The OJ window is suddenly minimized and the program is frozen. ---------------------------------------------------------------------- Comment By: michael michaud (michaudm) Date: 2013-04-21 10:49 Message: What do you mean by a sequence of Polygons ? Have you a stacktrace or a logfile ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=679906&aid=3611503&group_id=118054 ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
