HI Ede, > is this the DXF fix? if yes it will probably clash with future changes i have > planned for the plugin framework. every extension is supposed to get it's > private classloader in the future, that prefers jars in the order > lib/ext/extension-name/*.jar > lib/ext/*.jar > or default classloader > this way we will not be forced to sync dependency versions between different > extensions and core anymore e.g. two extensions using itext but different > versions. > > do you have a sourcecode repository (sources) for the dxf extension and an > example file? i could try to find a solution then in preparation of future > changes. Not yet for dxf, but I think you can test with the csv driver, which is in our svn. csv driver uses a more recent approach (datasource framework), but regarding classloading, it should be the same case. I'm not an expert in classloading (hence the recent bug on dxf), but I already had to deal with extension classloading problem in OpenProjectPlugIn and again last week when I tried to make DataSourceFileLayerLoader "recordable" : the problem is "how do you know which classloader to use when the class you want to load is only identified by its name ?". This is the case for datasources in project files (.jmp), and later or sooner for macro files.
Michaël > > ..ede > > On 08.10.2014 13:09, micha...@users.sourceforge.net wrote: >> Revision: 4065 >> http://sourceforge.net/p/jump-pilot/code/4065 >> Author: michaudm >> Date: 2014-10-08 11:08:59 +0000 (Wed, 08 Oct 2014) >> Log Message: >> ----------- >> Try to fix issue with classloader >> >> Modified Paths: >> -------------- >> >> core/trunk/src/org/openjump/core/ui/io/file/DataSourceFileLayerLoader.java >> >> Modified: >> core/trunk/src/org/openjump/core/ui/io/file/DataSourceFileLayerLoader.java >> =================================================================== >> --- >> core/trunk/src/org/openjump/core/ui/io/file/DataSourceFileLayerLoader.java >> 2014-10-07 06:37:34 UTC (rev 4064) >> +++ >> core/trunk/src/org/openjump/core/ui/io/file/DataSourceFileLayerLoader.java >> 2014-10-08 11:08:59 UTC (rev 4065) >> @@ -34,6 +34,7 @@ >> import java.util.List; >> import java.util.Map; >> >> +import com.vividsolutions.jump.workbench.plugin.PlugInManager; >> import com.vividsolutions.jump.workbench.plugin.Recordable; >> import com.vividsolutions.jump.workbench.plugin.Macro; >> import org.openjump.core.ui.util.ExceptionUtil; >> @@ -140,7 +141,9 @@ >> } >> >> public Object process(TaskMonitor monitor) throws >> ClassNotFoundException, URISyntaxException { >> - Class datasourceClass = >> this.getClass().getClassLoader().loadClass(getStringParam(DATASOURCE_CLASSNAME)); >> + PlugInManager plugInManager = >> workbenchContext.getWorkbench().getPlugInManager(); >> + ClassLoader pluginClassLoader = plugInManager.getClassLoader(); >> + Class datasourceClass = >> pluginClassLoader.loadClass(getStringParam(DATASOURCE_CLASSNAME)); >> DataSource dataSource = >> (DataSource)LangUtil.newInstance(datasourceClass); >> //Map<String, Object> properties = toProperties(uri, options); >> Map<String, Object> properties = getParameters(); >> >> This was sent by the SourceForge.net collaborative development platform, the >> world's largest Open Source development site. >> >> >> ------------------------------------------------------------------------------ >> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer >> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports >> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper >> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer >> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk >> _______________________________________________ >> Jump-pilot-svn-notify mailing list >> jump-pilot-svn-not...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-svn-notify >> > ------------------------------------------------------------------------------ > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer > http://p.sf.net/sfu/Zoho > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://p.sf.net/sfu/Zoho _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
