On 17.11.2014 22:40, edgar.sol...@web.de wrote:
> On 17.11.2014 21:55, Michael Michaud wrote:
>> Hi
>>> On 17.11.2014 20:15, Michael Michaud wrote:
>>>> Hi,
>>>>>>>> Indeed, Ede was right as the plugin works on any attribute.
>>>>>>>> In this context, adding a regex matcher makes sens (done).
>>>>>>>> I also added a case insensitive option which is not related to the 
>>>>>>>> geometry.type
>>>>>>>> attribute but made available for any attribute query, and as I was at 
>>>>>>>> it, I also
>>>>>>>> added a geometry.isEmpty, geometry.numHoles and geometry.dimension
>>>>>>>> attributes.
>>>>>> All these are little tools with much value sometimes. Case insensitive 
>>>>>> does not work for my exact use case because selection is not active for 
>>>>>> the equals condition (=) and there is not dedicated "like" condition for 
>>>>>> strings.
>>>> Ede, it seems to be a side-effect of your enhancement. Would you mind to
>>>> add "=" into the case insensitivity list of conditions ?
>>> does it seem intuitive to you guys that '=' is meant to do an equal 
>>> operation on strings? especially because in the list it is followed by math 
>>> function which definitely are not usable with strings. string functions 
>>> follow on the bottom of the list.
>> This is a good question.
>> I think the actual design favor simplicity with one set of operators for 
>> any kind of attribute : I checked that you can also use < or > for 
>> strings ;-)
>> The sign = is also used in SQL either for numbers or strings.
>> Simple Query plugin is "attribute type" sensitive, but it adds some 
>> complexity. Maybe we should keep this difference so that both plugins 
>> complement each other.
>>
>> Despite these few arguments, I'm not strongly opposed to have two 
>> different operators for number and for string equality if some of you 
>> find it more clear.
>>
> 
> ok, let me revisit the code tomorrow and add case insensitivity to each an 
> all in case rhey really already work on strings =).. ede
> 

done in rev.4081 ..ede

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to