On 13.12.2014 16:53, Giuseppe Aruta wrote: > Hi all, > In the last days I worked around to Kosmo code to port some enhancements > and tools into OpenJUMP that could be usefull. > > Among them, I want to submit these two ones ( I added to this mail, as a > extension) which are modified version of OJ CombineSelectedFeaturesPlugIn > and MergeSelectedFeaturesPlugIn classes, located on select feature popup > menu. > > These new plugins show a dialog where user can choose, within selected > feature, which attribute to copy to the new Merged (or new Combined) item. > I ported a new class to OJ from Kosmo: FeatureUnionDialog. And I used > another Kosmo class (FormUtil) to define some parameters for that dialog. > > I used original OJ classes which I modified following Kosmo code (and used > Kosmo dialog class)
while adding the proxy configuration of Kosmo i also had to reuse some of their code. for simplicity i kept their canonical names and integrated them as is afap into OJ codebase. this way we don't double code unnecessary when we port more stuff from Kosmo. when needed eg. for their I18N class, i patched their class to reuse our implementation. > I tested both plugin and seems to me that they work fine, on executing. > > I found problems on the undo action: in both plugins it restores all the > original selected feature except the one, choosed during the do process in > the dialog. I remember that this was a behaviour of an old version of > MergeSelectedFeaturesPlugIn that was recently corrected. Anyhow I used a > very recent code to modify MergeSelectedFeaturesPlugIn and > CombineSelectedFeaturesPlugIn. > > I add the plugins to this mail and I ask to the community an help to > correct this bug. well, if you primarily want it to be tested send it out on the user list. if your aim is however to have others to contribute code and this is going to be into OJ anyway i'd suggest to commit it early into the trunk so people can test it with the snapshots (easy) and other devs have ready naccess in case they wanna patch something up. > I will add these modifications to OJ NB by the time they will working fine, > if you agree, of coarse see above > In the next months I will submit other Kosmo enhancements I am working > around. nice.. > The new Combine and Merge Feature plugin, from this extension, are > activated both on "PlugIn>Test" menu and on Select Feature popup menu. > I also ported the translation into Finnic, German, Italian and Spanish from > Kosmo (I remember that Jukka was the author of Finnic language file) in case you are going to commit early, you are welcome to place them properly already in the testing stage. if you feel the need to place them more prominently under Plugins/Test, that's fine as well of course. so i'd say ..ede ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Jump-pilot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
