Michael, i forgot to cut the diff so you see the part. i mean addMouseListener(...) in LayerViewPanel s.b. ..ede
-------- Forwarded Message -------- Subject: [JPP-Devel] Fwd: SVN: [4589] core/trunk Date: Tue, 8 Dec 2015 17:46:48 +0100 From: [email protected] Reply-To: OpenJump develop and use <[email protected]> To: jump devel <[email protected]> Michael, can you please check that whatever the code i had to comment out fixed still works? there was no way around it,as cursor tools need to check that the layerview has the focus. thx ..ede -------- Forwarded Message -------- Subject: [JPP-Devel] SVN: [4589] core/trunk Date: Tue, 8 Dec 2015 16:43:41 +0000 From: [email protected] Reply-To: OpenJump develop and use <[email protected]> To: [email protected] Revision: 4589 http://sourceforge.net/p/jump-pilot/code/4589 Author: edso Date: 2015-12-08 16:43:40 +0000 (Tue, 08 Dec 2015) Log Message: ----------- try to bugfix "renaming layers or editing attributes in attribtab executes plugin/cursortool erronously via shortcut" and "shortcuts Strg+X/C/V etc. not working when editing layer names in TreeLayerNamePanel" Modified Paths: -------------- core/trunk/ChangeLog core/trunk/src/com/vividsolutions/jump/workbench/ui/LayerViewPanel.java core/trunk/src/com/vividsolutions/jump/workbench/ui/WorkbenchFrame.java core/trunk/src/com/vividsolutions/jump/workbench/ui/cursortool/AbstractCursorTool.java core/trunk/src/com/vividsolutions/jump/workbench/ui/cursortool/MultiClickTool.java Modified: core/trunk/ChangeLog =================================================================== --- core/trunk/ChangeLog 2015-12-08 16:26:31 UTC (rev 4588) +++ core/trunk/ChangeLog 2015-12-08 16:43:40 UTC (rev 4589) @@ -1,5 +1,10 @@ # for display continuity sake please use 2 spaces instead of tabs +2015-12-08 ede + * bugfix "renaming layers or editing attributes in attribtab executes + plugin/cursortool erronously via shortcut" and "shortcuts Strg+X/C/V etc. + not working when editing layer names in TreeLayerNamePanel" + 2015-12-06 mmichaud <[email protected]> * Improved CutFeatureTool * add MakeValidPlugIn in Tools>Analysis to repair invalid geometries Modified: core/trunk/src/com/vividsolutions/jump/workbench/ui/LayerViewPanel.java =================================================================== --- core/trunk/src/com/vividsolutions/jump/workbench/ui/LayerViewPanel.java 2015-12-08 16:26:31 UTC (rev 4588) +++ core/trunk/src/com/vividsolutions/jump/workbench/ui/LayerViewPanel.java 2015-12-08 16:43:40 UTC (rev 4589) @@ -190,26 +190,30 @@ }); this.setLayout(borderLayout1); + final LayerViewPanel lvp = this; addMouseListener(new MouseAdapter() { public void mouseEntered(MouseEvent e) { - // Re-activate WorkbenchFrame. Otherwise, user may try - // entering - // a quasi-mode by pressing a modifier key -- nothing will - // happen because the - // WorkbenchFrame does not have focus. [Jon Aquino] - // JavaDoc for #toFront says some platforms will not - // activate the window. - // So use #requestFocus instead. [Jon Aquino 12/9/2003] - WorkbenchFrame workbenchFrame = getWorkBenchFrame(); - // [mmichaud 2012-02-24] get rid of the focus problem between - // OpenJUMP and BeanshellEditor (bug #3487686) - Window focusedWindow = KeyboardFocusManager - .getCurrentKeyboardFocusManager().getFocusedWindow(); - if (focusedWindow != workbenchFrame) - return; - if (workbenchFrame != null && !workbenchFrame.isActive()) { - workbenchFrame.requestFocus(); - } + // cursor tools and other shortcutables depend + // on properly focussed ui components + lvp.requestFocusInWindow(); +// // Re-activate WorkbenchFrame. Otherwise, user may try +// // entering +// // a quasi-mode by pressing a modifier key -- nothing will +// // happen because the +// // WorkbenchFrame does not have focus. [Jon Aquino] +// // JavaDoc for #toFront says some platforms will not +// // activate the window. +// // So use #requestFocus instead. [Jon Aquino 12/9/2003] +// WorkbenchFrame workbenchFrame = getWorkBenchFrame(); +// // [mmichaud 2012-02-24] get rid of the focus problem between +// // OpenJUMP and BeanshellEditor (bug #3487686) +// Window focusedWindow = KeyboardFocusManager +// .getCurrentKeyboardFocusManager().getFocusedWindow(); +// if (focusedWindow != workbenchFrame) +// return; +// if (workbenchFrame != null && !workbenchFrame.isActive()) { +// workbenchFrame.requestFocus(); +// } } }); ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 _______________________________________________ Jump-pilot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
