Revision: 5141
http://sourceforge.net/p/jump-pilot/code/5141
Author: edso
Date: 2016-11-02 15:38:01 +0000 (Wed, 02 Nov 2016)
Log Message:
-----------
make Logger more robust
Modified Paths:
--------------
core/trunk/src/com/vividsolutions/jump/workbench/Logger.java
Modified: core/trunk/src/com/vividsolutions/jump/workbench/Logger.java
===================================================================
--- core/trunk/src/com/vividsolutions/jump/workbench/Logger.java
2016-11-02 13:44:14 UTC (rev 5140)
+++ core/trunk/src/com/vividsolutions/jump/workbench/Logger.java
2016-11-02 15:38:01 UTC (rev 5141)
@@ -108,6 +108,7 @@
*/
public static void log(String msg, Throwable t, Level logLevel,
StackTraceElement calledFrom) {
+
// get caller
StackTraceElement element = getCaller(calledFrom);
@@ -125,7 +126,17 @@
if (element != null && !loggerLevel.isGreaterOrEqual(Level.INFO))
msgAppend = " at " + element + "";
- // use t message if null given
+ // empty log messages provoke this error line for devs to fix the cause
+ if (msg!=null && msg.isEmpty()) {
+ error("Logger: string message was empty but not null at "+element);
+ }
+
+ // throw error on empty log entries
+ if (t == null && msg == null)
+ throw new IllegalArgumentException(
+ "Logger: either message or throwable must be given.");
+
+ // use throwable's message if null message given
if (msg == null)
msg = t.getMessage();
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Jump-pilot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
